You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "troychiu (via GitHub)" <gi...@apache.org> on 2023/05/01 01:54:07 UTC
[GitHub] [yunikorn-core] troychiu opened a new pull request, #534: [YUNIKORN-1690] remove redundant if else
troychiu opened a new pull request, #534:
URL: https://github.com/apache/yunikorn-core/pull/534
### What is this PR for?
Remove the redundant if else in multiple places
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1690
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #534: [YUNIKORN-1690] remove redundant if else
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #534:
URL: https://github.com/apache/yunikorn-core/pull/534#issuecomment-1530155107
## [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/534?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#534](https://codecov.io/gh/apache/yunikorn-core/pull/534?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd37937) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/cec575e4b8989eac158976320d6506ff7c486baf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cec575e) will **decrease** coverage by `0.03%`.
> The diff coverage is `70.00%`.
```diff
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 75.05% 75.02% -0.03%
==========================================
Files 70 70
Lines 11323 11328 +5
==========================================
+ Hits 8498 8499 +1
- Misses 2528 2531 +3
- Partials 297 298 +1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/yunikorn-core/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `76.80% <0.00%> (-0.07%)` | :arrow_down: |
| [pkg/scheduler/objects/sorters.go](https://codecov.io/gh/apache/yunikorn-core/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3NvcnRlcnMuZ28=) | `96.51% <87.50%> (-1.71%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #534: [YUNIKORN-1690] remove redundant if else
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #534: [YUNIKORN-1690] remove redundant if else
URL: https://github.com/apache/yunikorn-core/pull/534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org