[GitHub] [incubator-superset] ktmud commented on a change in pull request #10219: fix: better backward compatibility for table viz

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219#discussion_r448539627



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
##########
@@ -103,7 +103,8 @@ describe('Visualization > Table', () => {
   it('Test table with columns and row limit', () => {
     const formData = {
       ...VIZ_DEFAULTS,
-      query_mode: 'raw',
+      // should still work when query_mode is not-set/invalid
+      query_mode: undefined,

Review comment:
       There is another test below that sets `query_mode` with a value. Can make it more explicit though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org