You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Vladimir Limansky (JIRA)" <ji...@apache.org> on 2009/10/23 01:44:51 UTC

[jira] Created: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
-----------------------------------------------------------------

                 Key: WW-3293
                 URL: https://issues.apache.org/struts/browse/WW-3293
             Project: Struts 2
          Issue Type: New Feature
          Components: "New" API, Plugin - Portlet
    Affects Versions: 2.1.0
         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
            Reporter: Vladimir Limansky


Guys,

In this issue I will attach *.diff file with all files changed to support portlet theme
All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components

Also new parameters support was added NOT changing struts.tld file

1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
The element wrapper will be defined as follows:
wrapper = headerWrapper;  
if (wrapper == null) 
   wrapper = defaultHeaderWrapper;
if (wrapper == null) 
   wrapper = default;
2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
3. colspan
4. rowspan 
5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
6. labelwidth (could be defined in pixels and percents)
7. labelalign
8. 'labelseparator' and 'labelStyle'
9. width


Parameters could be used as follows:

            <s:select 
                name="${paramName}" >

                <s:param name="labelseparator">
                </s:param>
                <s:param name="labelwidth" value="%{'20%'}" />
                <s:param name="width" value="%{'20%'}" />
            </s:select>


Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)

Any questions are appreciated.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46960#action_46960 ] 

Nils-Helge Garli commented on WW-3293:
--------------------------------------

In that case, please attach the patch to to WW-3287 instead.

> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch, sibutu_struts_dojo_plugin.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46951#action_46951 ] 

Nils-Helge Garli commented on WW-3293:
--------------------------------------

Is this supposed to be a patch for  WW-3287?

> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Vladimir Limansky (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46953#action_46953 ] 

Vladimir Limansky commented on WW-3293:
---------------------------------------

Nils,

Yes this is correct
According to JSR-286 (portlet 2.0) and JSR-168 (portlet 1.0) css class names used in the portlet should follow the following specification

portlet css classes supported by the patch:

portlet-table-body
portlet-form-label
portlet-form-input-field
portlet-form-button
portlet-form-field-label
portlet-form-field
portlet-font





> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch, sibutu_struts_dojo_plugin.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Vladimir Limansky (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46962#action_46962 ] 

Vladimir Limansky commented on WW-3293:
---------------------------------------

For dojo plugin we did not change all elements to support portlet theme 
list of changed elements

autocompleter
controlheader
datetimepicker
head
submit

> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch, sibutu_struts_dojo_plugin.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nils-Helge Garli resolved WW-3293.
----------------------------------

    Resolution: Duplicate

> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch, sibutu_struts_dojo_plugin.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Vladimir Limansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Limansky updated WW-3293:
----------------------------------

    Attachment: sibutu_portlet_theme.patch

Sibutu portlet theme patch

> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Vladimir Limansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Limansky updated WW-3293:
----------------------------------

    Attachment: sibutu_struts_dojo_plugin.patch

Sibutu struts dojo plugin portlet theme

> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch, sibutu_struts_dojo_plugin.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3293) Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file

Posted by "Vladimir Limansky (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46964#action_46964 ] 

Vladimir Limansky commented on WW-3293:
---------------------------------------

Nils:
> In that case, please attach the patch to to WW-3287 instead. 
Done

> Sibutu (http://code.google.com/p/sibutu/) portlet theme diff file
> -----------------------------------------------------------------
>
>                 Key: WW-3293
>                 URL: https://issues.apache.org/struts/browse/WW-3293
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: "New" API, Plugin - Portlet
>    Affects Versions: 2.1.0
>         Environment: struts 2.1.0 struts2-portlet2-plugin struts2-dojo-plugin-2.1.0 sibutu portal/portlet container
>            Reporter: Vladimir Limansky
>         Attachments: sibutu_portlet_theme.patch, sibutu_struts_dojo_plugin.patch
>
>
> Guys,
> In this issue I will attach *.diff file with all files changed to support portlet theme
> All struts GUI compinents were changed (s:xxx). So vast majority of changes are related to <s:form> and it's components
> Also new parameters support was added NOT changing struts.tld file
> 1. headerWrapper (none|default|'<td><tr>') - none='', default='<td class="portlet-table-body">' 
> The element wrapper will be defined as follows:
> wrapper = headerWrapper;  
> if (wrapper == null) 
>    wrapper = defaultHeaderWrapper;
> if (wrapper == null) 
>    wrapper = default;
> 2. footerWrapper (none|default|'</td></tr>') - none='', default='</td>'
> 3. colspan
> 4. rowspan 
> 5. labelcolspan (there's no such parameter as 'labelrowspan', labelrowspan = rowspan)
> 6. labelwidth (could be defined in pixels and percents)
> 7. labelalign
> 8. 'labelseparator' and 'labelStyle'
> 9. width
> Parameters could be used as follows:
>             <s:select 
>                 name="${paramName}" >
>                 <s:param name="labelseparator">
>                 </s:param>
>                 <s:param name="labelwidth" value="%{'20%'}" />
>                 <s:param name="width" value="%{'20%'}" />
>             </s:select>
> Also some changes to struts-dojo plugin were done (I'll submit *.diff file for dojo later)
> Any questions are appreciated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.