You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/05/12 01:28:00 UTC
[jira] [Commented] (HBASE-13585) HRegionFileSystem#splitStoreFile()
finishes without closing the file handle in some situation
[ https://issues.apache.org/jira/browse/HBASE-13585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538870#comment-14538870 ]
Hudson commented on HBASE-13585:
--------------------------------
FAILURE: Integrated in HBase-0.98 #983 (See [https://builds.apache.org/job/HBase-0.98/983/])
HBASE-13585 HRegionFileSystem#splitStoreFile() finishes without closing the file handle in some situation (Stephen Yuan Jiang) (apurtell: rev 368329dec9d0c2fbed9ddd53ccf503ff892e62bc)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
> HRegionFileSystem#splitStoreFile() finishes without closing the file handle in some situation
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-13585
> URL: https://issues.apache.org/jira/browse/HBASE-13585
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 2.0.0, 1.1.0, 1.2.0
> Environment: Windows
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0
>
> Attachments: HBASE-13585-0.98.patch, HBASE-13585.v1-mater.patch
>
>
> HRegionFileSystem#splitStoreFile() opens a reader and does not close it in some situation.
> In Windows, TestSplitTransaction#testWholesomeSplit() consistently failed due to open file handle left at the end of test
> {noformat}
> Failed delete of C:/hbase/hbase-server/target/test-data/b470118c-978a-4915-8a12-b29b2c966beb/org.apache.hadoop.hbase.regionserver.TestSplitTransaction/data/default/table/a578b53b3c3a947c5f617c51ccb982cf
> Stacktrace
> java.io.IOException: Failed delete of C:/hbase/hbase-server/target/test-data/b470118c-978a-4915-8a12-b29b2c966beb/org.apache.hadoop.hbase.regionserver.TestSplitTransaction/data/default/table/a578b53b3c3a947c5f617c51ccb982cf
> at org.apache.hadoop.hbase.regionserver.TestSplitTransaction.teardown(TestSplitTransaction.java:106)
> Standard Error
> 2015-04-26 12:57:43,863 WARN [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\.0519debf2b934245a9a8c3d7cfc0f51d.crc]: it still exists.
> 2015-04-26 12:57:43,864 WARN [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\.45fd4e817ce64759abc6e982a5c0b830.crc]: it still exists.
> 2015-04-26 12:57:43,865 WARN [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\.8e6bc752c9fc414abfe085f8959dce94.crc]: it still exists.
> 2015-04-26 12:57:43,870 WARN [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\0519debf2b934245a9a8c3d7cfc0f51d]: it still exists.
> 2015-04-26 12:57:43,870 WARN [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\45fd4e817ce64759abc6e982a5c0b830]: it still exists.
> 2015-04-26 12:57:43,871 WARN [main] fs.FileUtil(187): Failed to delete file or dir [C:\hbase\hbase-server\target\test-data\b470118c-978a-4915-8a12-b29b2c966beb\org.apache.hadoop.hbase.regionserver.TestSplitTransaction\data\default\table\a578b53b3c3a947c5f617c51ccb982cf\info\8e6bc752c9fc414abfe085f8959dce94]: it still exists.
> {noformat}
> HBASE-8300 tried to fix this issue by adding 'StoreFile#closeReader()' call. However, after the open reader calls, there are 4 'return null' calls before the close call. When I run TestSplitTransaction#testWholesomeSplit(), 2 of the 'return null' calls were hit multiple times (which means the opened file is not closed).
> The fix needs to make sure that StoreFile#closeReader() is called in all situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)