You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/07/24 13:15:33 UTC
Review Request 61081: Considered ResourceProvider 'name' and 'type' in
equality checks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61081/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Repository: mesos
Description
-------
Considered ResourceProvider 'name' and 'type' in equality checks.
Diffs
-----
src/common/type_utils.cpp 031344c392a145ae72e8cecdae92d95fa930d328
src/v1/mesos.cpp e5143e1f5fa85ad1c61fec518b4295b607d27d38
Diff: https://reviews.apache.org/r/61081/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 61081: Considered ResourceProvider 'name' and
'type' in equality checks.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61081/#review181224
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 24, 2017, 1:15 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61081/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 1:15 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Considered ResourceProvider 'name' and 'type' in equality checks.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp 031344c392a145ae72e8cecdae92d95fa930d328
> src/v1/mesos.cpp e5143e1f5fa85ad1c61fec518b4295b607d27d38
>
>
> Diff: https://reviews.apache.org/r/61081/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61081: Considered ResourceProvider 'name' and
'type' in equality checks.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61081/#review181212
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On July 24, 2017, 3:15 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61081/
> -----------------------------------------------------------
>
> (Updated July 24, 2017, 3:15 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Considered ResourceProvider 'name' and 'type' in equality checks.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp 031344c392a145ae72e8cecdae92d95fa930d328
> src/v1/mesos.cpp e5143e1f5fa85ad1c61fec518b4295b607d27d38
>
>
> Diff: https://reviews.apache.org/r/61081/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>