[jira] [Commented] (HIVE-12418) HiveHBaseTableInputFormat.getRecordReader() causes Zookeeper connection leak.

["Thejas M Nair (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-12418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085944#comment-15085944 ] 

Thejas M Nair commented on HIVE-12418:
--------------------------------------

bq. Also overrides the Object.finalize() that closes these resources too in cases when RecordReader.close() is never called.
Is that expected to happen ?
We should avoid the use of finalizers as far as possible. See one article on that - https://plumbr.eu/blog/garbage-collection/debugging-to-understand-finalizer


> HiveHBaseTableInputFormat.getRecordReader() causes Zookeeper connection leak.
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-12418
>                 URL: https://issues.apache.org/jira/browse/HIVE-12418
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 1.1.0
>            Reporter: Naveen Gangam
>            Assignee: Naveen Gangam
>             Fix For: 2.0.0
>
>         Attachments: HIVE-12418.patch
>
>
>   @Override
>   public RecordReader<ImmutableBytesWritable, ResultWritable> getRecordReader(
> ...
> ...
>  setHTable(HiveHBaseInputFormatUtil.getTable(jobConf));
> ...
> The HiveHBaseInputFormatUtil.getTable() creates new ZooKeeper connections(when HTable instance is created) which are never closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)