You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/05 18:10:41 UTC
[jira] [Commented] (DRILL-5415) Improve Fixture Builder to
configure client properties and keep collection type properties for server
[ https://issues.apache.org/jira/browse/DRILL-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957348#comment-15957348 ]
ASF GitHub Bot commented on DRILL-5415:
---------------------------------------
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/807
DRILL-5415: Improve Fixture Builder to configure client properties an…
…d keep collection type properties for server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sohami/drill DRILL-5415
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/807.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #807
----
commit 1608487142f6d1f22e70eed00b508b8006200325
Author: Sorabh Hamirwasia <sh...@maprtech.com>
Date: 2017-04-05T18:04:58Z
DRILL-5415: Improve Fixture Builder to configure client properties and keep collection type properties for server
----
> Improve Fixture Builder to configure client properties and keep collection type properties for server
> -----------------------------------------------------------------------------------------------------
>
> Key: DRILL-5415
> URL: https://issues.apache.org/jira/browse/DRILL-5415
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.11.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Minor
> Fix For: 1.11.0
>
>
> There are 2 improvements which are made as part of this pull request.
> 1) The Fixture Builder framework converts all the config properties for Drillbit into string type. But there are certain configurations for authentication (like auth.mechanism) which are expected to be list type. Thus there will be failure during type check. Change to keep collections type config value as is and insert those config value after string types are inserted.
> 2) The Fixture Builder framework when builds it tries to apply any system options / session options (if set) for which it creates a default client. Hence with cluster enabled for authentication this default client will not provide any connection parameters for authentication and will fail to connect. Allow Fixture Builder to accept client related properties as well so that can be used while creating default client to connect to cluster.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)