[GitHub] [kafka] yashmayya commented on pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

["yashmayya (via GitHub)" <gi...@apache.org>]

yashmayya commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1520127170

   @vamossagar12 the behavior in `MemoryOffsetBackingStore` should probably be changed - if it fails to shutdown cleanly and throws an exception, it'll cause further resource closures to be skipped in the worker - https://github.com/apache/kafka/blob/2271e748a11919d07698ebce759dca2e3075596a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java#L241-L264
   
   Also, I'm not sure why the `Worker` can't use this new utility method for closing its executor? The main difference is the additional call to `awaitTermination` after the call to `shutdownNow` which seems redundant anyway. There's also the preservation of the thread's interrupt status which I'm thinking maybe the `ThreadUtils::shutdownExecutorServiceQuietly` method should also be doing, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org