You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2009/03/15 16:26:50 UTC
[jira] Created: (LANG-494) CharSet sub-classes cannot be made
thread-safe
CharSet sub-classes cannot be made thread-safe
----------------------------------------------
Key: LANG-494
URL: https://issues.apache.org/jira/browse/LANG-494
Project: Commons Lang
Issue Type: Bug
Reporter: Sebb
AFAICT, CharSet sub-classes cannot be made thread-safe.
This is because the HashMap and HashSet collections are not thread-safe.
If a sub-class updates COMMON, there is no guarantee that getInstance() will see the update.
In the case of the instance variable "set", the sub-class could override all the read/write methods to provide thread-safety.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LANG-494) CharSet sub-classes cannot be made
thread-safe
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated LANG-494:
---------------------------------
Fix Version/s: (was: 3.0)
2.5
> CharSet sub-classes cannot be made thread-safe
> ----------------------------------------------
>
> Key: LANG-494
> URL: https://issues.apache.org/jira/browse/LANG-494
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Reporter: Sebb
> Fix For: 2.5
>
>
> AFAICT, CharSet sub-classes cannot be made thread-safe.
> This is because the HashMap and HashSet collections are not thread-safe.
> If a sub-class updates COMMON, there is no guarantee that getInstance() will see the update.
> In the case of the instance variable "set", the sub-class could override all the read/write methods to provide thread-safety.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LANG-494) CharSet sub-classes cannot be made
thread-safe
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated LANG-494:
-------------------------------
Fix Version/s: 3.0
> CharSet sub-classes cannot be made thread-safe
> ----------------------------------------------
>
> Key: LANG-494
> URL: https://issues.apache.org/jira/browse/LANG-494
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> AFAICT, CharSet sub-classes cannot be made thread-safe.
> This is because the HashMap and HashSet collections are not thread-safe.
> If a sub-class updates COMMON, there is no guarantee that getInstance() will see the update.
> In the case of the instance variable "set", the sub-class could override all the read/write methods to provide thread-safety.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LANG-494) CharSet sub-classes cannot be made
thread-safe
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell closed LANG-494.
------------------------------
Resolution: Fixed
svn ci -m "Synchronizing the COMMON Map so that getInstance doesn't miss a put from a subclass in another thread. LANG-494"
Sending src/main/java/org/apache/commons/lang3/CharSet.java
Transmitting file data .
Committed revision 897408.
> CharSet sub-classes cannot be made thread-safe
> ----------------------------------------------
>
> Key: LANG-494
> URL: https://issues.apache.org/jira/browse/LANG-494
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Reporter: Sebb
> Fix For: 3.0
>
>
> AFAICT, CharSet sub-classes cannot be made thread-safe.
> This is because the HashMap and HashSet collections are not thread-safe.
> If a sub-class updates COMMON, there is no guarantee that getInstance() will see the update.
> In the case of the instance variable "set", the sub-class could override all the read/write methods to provide thread-safety.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-494) CharSet sub-classes cannot be made
thread-safe
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741723#action_12741723 ]
Henri Yandell commented on LANG-494:
------------------------------------
So, do we wrap it in a synchronized call?
> CharSet sub-classes cannot be made thread-safe
> ----------------------------------------------
>
> Key: LANG-494
> URL: https://issues.apache.org/jira/browse/LANG-494
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> AFAICT, CharSet sub-classes cannot be made thread-safe.
> This is because the HashMap and HashSet collections are not thread-safe.
> If a sub-class updates COMMON, there is no guarantee that getInstance() will see the update.
> In the case of the instance variable "set", the sub-class could override all the read/write methods to provide thread-safety.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (LANG-494) CharSet sub-classes cannot
be made thread-safe
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741723#action_12741723 ]
Henri Yandell edited comment on LANG-494 at 8/10/09 11:44 PM:
--------------------------------------------------------------
So, do we wrap it in a Collections synchronized wrapper?
was (Author: bayard):
So, do we wrap it in a synchronized call?
> CharSet sub-classes cannot be made thread-safe
> ----------------------------------------------
>
> Key: LANG-494
> URL: https://issues.apache.org/jira/browse/LANG-494
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> AFAICT, CharSet sub-classes cannot be made thread-safe.
> This is because the HashMap and HashSet collections are not thread-safe.
> If a sub-class updates COMMON, there is no guarantee that getInstance() will see the update.
> In the case of the instance variable "set", the sub-class could override all the read/write methods to provide thread-safety.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.