You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/30 08:02:51 UTC

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7542: Fix NPE when calling `Analyzer.getContext()` in partition pruning related logic.

EmmyMiao87 commented on a change in pull request #7542:
URL: https://github.com/apache/incubator-doris/pull/7542#discussion_r776609106



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java
##########
@@ -445,6 +445,15 @@ private void computeInaccurateCardinality() {
         return partitionPruner.prune();
     }
 
+    private boolean partitionPruneV2Enabled() {
+        ConnectContext context = analyzer.getContext();
+        if (context == null) {
+            return false;

Review comment:
       ```suggestion
               return true;
   ```

##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/ScanNode.java
##########
@@ -133,6 +134,11 @@ public void computeColumnFilter() {
                 columnFilters.put(column.getName(), keyFilter);
             }
 
+            ConnectContext context = analyzer.getContext();

Review comment:
       default use V2?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org