You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/07/26 01:41:06 UTC

[GitHub] cckellogg commented on a change in pull request #2237: [website] Fix security page links and includes

cckellogg commented on a change in pull request #2237:  [website] Fix security page links and includes
URL: https://github.com/apache/incubator-pulsar/pull/2237#discussion_r205309630
 
 

 ##########
 File path: site2/website/scripts/replace.js
 ##########
 @@ -49,7 +49,7 @@ const versions = getVersions();
 const latestVersion = versions[0];
 
 const from = [
-  /pulsar:version/g, 
+  /{{pulsar:version}}/g, 
 
 Review comment:
   I'm curious as to why the {{}} were added? Should we be consistent with the other variables (pulsar:variable_name)? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services