You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/10/08 23:30:40 UTC
[GitHub] [tomcat] t-gergely opened a new pull request #453: AsyncFileHandler: try to flush on close
t-gergely opened a new pull request #453:
URL: https://github.com/apache/tomcat/pull/453
When shutting down Tomcat on a single core server, some log entries can be lost. (E.g. the last ones added by `contextDestroyed`.) This patch tries to prevent that. It's not very elegant, but it works for me.
(Should you want to rewrite `AsyncFileHandler` instead, you might also want to drop the `org.apache.juli.AsyncLoggerPollInterval` property, since using that doesn't make any sense to me.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #453: AsyncFileHandler: try to flush on close
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #453:
URL: https://github.com/apache/tomcat/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #453: AsyncFileHandler: try to flush on close
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #453:
URL: https://github.com/apache/tomcat/pull/453#issuecomment-979270093
Thanks for the PR. I applied a slightly different fix with an eye to a larger refactoring that would start/stop the thread as handlers were open/closed.
I also removed the system property. I agree there is no need for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org