You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/01/29 17:53:08 UTC
Review Request 56062: Fix flapping TestRunnerKillProcessGroup test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56062/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1809
https://issues.apache.org/jira/browse/AURORA-1809
Repository: aurora
Description
-------
The test was working when run in isolation, but failed when executing the entire Thermos test suite.
Diffs
-----
src/test/python/apache/thermos/core/test_staged_kill.py 4de735f94d9faa9772f9d336186ddd13ea78988d
Diff: https://reviews.apache.org/r/56062/diff/
Testing
-------
./pants test.pytest src/test/python/apache/thermos:: -- -v
Thanks,
Stephan Erb
Re: Review Request 56062: Fix flapping TestRunnerKillProcessGroup test
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56062/#review163564
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 29, 2017, 9:53 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56062/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2017, 9:53 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1809
> https://issues.apache.org/jira/browse/AURORA-1809
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The test was working when run in isolation, but failed when executing the entire Thermos test suite.
>
>
> Diffs
> -----
>
> src/test/python/apache/thermos/core/test_staged_kill.py 4de735f94d9faa9772f9d336186ddd13ea78988d
>
> Diff: https://reviews.apache.org/r/56062/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest src/test/python/apache/thermos:: -- -v
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 56062: Fix flapping TestRunnerKillProcessGroup test
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56062/#review163440
-----------------------------------------------------------
Ship it!
Master (1217fc8) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 29, 2017, 5:53 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56062/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2017, 5:53 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1809
> https://issues.apache.org/jira/browse/AURORA-1809
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The test was working when run in isolation, but failed when executing the entire Thermos test suite.
>
>
> Diffs
> -----
>
> src/test/python/apache/thermos/core/test_staged_kill.py 4de735f94d9faa9772f9d336186ddd13ea78988d
>
> Diff: https://reviews.apache.org/r/56062/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest src/test/python/apache/thermos:: -- -v
>
>
> Thanks,
>
> Stephan Erb
>
>