You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2019/06/04 03:24:00 UTC
[jira] [Commented] (HBASE-22453) A "NullPointerException" could be
thrown; "tableDescriptor" is nullable
[ https://issues.apache.org/jira/browse/HBASE-22453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855264#comment-16855264 ]
Hadoop QA commented on HBASE-22453:
-----------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange} 0m 0s{color} | {color:orange} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 39s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 22s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 12m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 17m 5s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 37s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-272/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/272 |
| JIRA Issue | HBASE-22453 |
| Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 499134e6c5c9 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 26037854ad |
| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-272/3/testReport/ |
| Max. process+thread count | 4472 (vs. ulimit of 10000) |
| modules | C: hbase-backup U: hbase-backup |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-272/3/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> A "NullPointerException" could be thrown; "tableDescriptor" is nullable
> -----------------------------------------------------------------------
>
> Key: HBASE-22453
> URL: https://issues.apache.org/jira/browse/HBASE-22453
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
> Affects Versions: 2.0.0, 2.1.2, 2.1.4
> Reporter: lixiaobao
> Assignee: lixiaobao
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-22453.patch
>
>
> In hbase-backup model the class "org.apache.hadoop.hbase.backup.util.RestoreTool"'s method incrementalRestoreTable(),A "NullPointerException" could be thrown; "tableDescriptor" is nullable here.
> {code:java}
> // adjust table schema
> for (int i = 0; i < tableNames.length; i++) {
> TableName tableName = tableNames[i];
> TableDescriptor tableDescriptor = getTableDescriptor(fileSys, tableName, incrBackupId);
> LOG.debug("Found descriptor " + tableDescriptor + " through " + incrBackupId);
> TableName newTableName = newTableNames[i];
> TableDescriptor newTableDescriptor = admin.getDescriptor(newTableName);
> List<ColumnFamilyDescriptor> families = Arrays.asList(tableDescriptor.getColumnFamilies());
> List<ColumnFamilyDescriptor> existingFamilies =
> Arrays.asList(newTableDescriptor.getColumnFamilies());
> TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(newTableDescriptor);
> boolean schemaChangeNeeded = false;
> for (ColumnFamilyDescriptor family : families) {
> if (!existingFamilies.contains(family)) {
> builder.setColumnFamily(family);
> schemaChangeNeeded = true;
> }
> }
> for (ColumnFamilyDescriptor family : existingFamilies) {
> if (!families.contains(family)) {
> builder.removeColumnFamily(family.getName());
> schemaChangeNeeded = true;
> }
> }
> if (schemaChangeNeeded) {
> modifyTableSync(conn, builder.build());
> LOG.info("Changed " + newTableDescriptor.getTableName() + " to: " + newTableDescriptor);
> }
> }
> RestoreJob restoreService = BackupRestoreFactory.getRestoreJob(conf);
> restoreService.run(logDirs, tableNames, newTableNames, false);
> }
> //代码占位符
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)