You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/23 14:09:03 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #10785: ARROW-13434: [R] group_by() with an unnammed expression

nealrichardson commented on a change in pull request #10785:
URL: https://github.com/apache/arrow/pull/10785#discussion_r675593809



##########
File path: r/R/dplyr-group-by.R
##########
@@ -18,16 +18,33 @@
 
 # The following S3 methods are registered on load if dplyr is present
 
+#' @importFrom rlang quo_name

Review comment:
       I think this is about the `@importFrom`, which Nic is right, we have most of them grouped in one place. I'm indifferent about how we do it but probably makes sense to follow convention and for these rlang ones at least, which tend to get used in multiple places, keep them grouped in arrow-package.R




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org