You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by Keiichi Fujino <kf...@apache.org> on 2013/03/28 08:59:35 UTC

Remove JvmRouteSessionIDBinderListener and SessionIDMessage.

Hi.

In the current implementation, JvmRouteBinderValve#changeSessionID
uses Manager#changeSessionId
in order to change session ID.
see r1446072, r1446077, r1461960.

As a result, The following classes are no longer used.
-JvmRouteSessionIDBinderListener
-SessionIDMessage

I'm going to remove these class.

Any objections and comment?

-- 
Keiichi.Fujino

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Remove JvmRouteSessionIDBinderListener and SessionIDMessage.

Posted by Mark Thomas <ma...@apache.org>.

Keiichi Fujino <kf...@apache.org> wrote:

>Hi.
>
>In the current implementation, JvmRouteBinderValve#changeSessionID
>uses Manager#changeSessionId
>in order to change session ID.
>see r1446072, r1446077, r1461960.
>
>As a result, The following classes are no longer used.
>-JvmRouteSessionIDBinderListener
>-SessionIDMessage
>
>I'm going to remove these class.
>
>Any objections and comment?

+1 - I'm always in favour of deleting code!

The remove classes should be marked as deprecated (with an explanation) just in case someone is depending on these.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org