You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Rui Chen <ch...@gmail.com> on 2020/04/18 07:17:36 UTC
Review Request 72385: Add test cleanup for TestHCatLoaderEncryption
and TestSessionManagerMetrics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72385/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
1.Test cases in TestHCatLoaderEncryption apply wrong test.jks in
hive/ql/target path, it casue tests failing when we run some ql tests,
then run TestHCatLoaderEncryption in local, fix it using TEST_DATA_DIR.
2.Add tearDown method to clean up static metrics instance, to avoid
impacting each other between test cases in one class.
Diffs
-----
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java beb4fe9f4b92d8582fff414d284d58c61368c53c
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 2eb07eee2801c5e968a684b13f557efae1705b6a
Diff: https://reviews.apache.org/r/72385/diff/1/
Testing
-------
Thanks,
Rui Chen
Re: Review Request 72385: HIVE-23219: Add test cleanup for
TestHCatLoaderEncryption and TestSessionManagerMetrics
Posted by Rui Chen <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72385/
-----------------------------------------------------------
(Updated 四月 18, 2020, 7:37 a.m.)
Review request for hive.
Summary (updated)
-----------------
HIVE-23219: Add test cleanup for TestHCatLoaderEncryption and TestSessionManagerMetrics
Repository: hive-git
Description
-------
1.Test cases in TestHCatLoaderEncryption apply wrong test.jks in
hive/ql/target path, it casue tests failing when we run some ql tests,
then run TestHCatLoaderEncryption in local, fix it using TEST_DATA_DIR.
2.Add tearDown method to clean up static metrics instance, to avoid
impacting each other between test cases in one class.
Diffs
-----
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderEncryption.java beb4fe9f4b92d8582fff414d284d58c61368c53c
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java 2eb07eee2801c5e968a684b13f557efae1705b6a
Diff: https://reviews.apache.org/r/72385/diff/1/
Testing
-------
Thanks,
Rui Chen