You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/10/06 14:02:10 UTC
Re: Review Request 62161: Update boost version.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/
-----------------------------------------------------------
(Updated Oct. 6, 2017, 2:02 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Repository: mesos
Description
-------
Update boost version.
Diffs (updated)
-----
3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
3rdparty/boost-1.65.0.tar.gz PRE-CREATION
3rdparty/cmake/Versions.cmake 958629642
3rdparty/versions.am 82d66be7d
Diff: https://reviews.apache.org/r/62161/diff/4/
Changes: https://reviews.apache.org/r/62161/diff/3-4/
Testing
-------
File Attachments (updated)
----------------
0001-Update-boost-version.patch
https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
Thanks,
Benno Evers
Re: Review Request 62161: Update boost version.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Nov. 7, 2017, 4:26 p.m., Benjamin Bannier wrote:
> > 3rdparty/versions.am
> > Line 22 (original), 22 (patched)
> > <https://reviews.apache.org/r/62161/diff/4/?file=1847488#file1847488line22>
> >
> > This patch in general seems to trigger the issue fixed in https://reviews.apache.org/r/63622/. Could you move that one before this patch to keep all patches compilable.
I meant https://reviews.apache.org/r/62444/ of course.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/#review190316
-----------------------------------------------------------
On Oct. 6, 2017, 4:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62161/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 4:02 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update boost version.
>
>
> Diffs
> -----
>
> 3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
> 3rdparty/boost-1.65.0.tar.gz PRE-CREATION
> 3rdparty/cmake/Versions.cmake 958629642
> 3rdparty/versions.am 82d66be7d
>
>
> Diff: https://reviews.apache.org/r/62161/diff/4/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> 0001-Update-boost-version.patch
> https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62161: Update boost version.
Posted by Benno Evers <be...@mesosphere.com>.
> On Nov. 7, 2017, 3:26 p.m., Benjamin Bannier wrote:
> > 3rdparty/versions.am
> > Line 22 (original), 22 (patched)
> > <https://reviews.apache.org/r/62161/diff/4/?file=1847488#file1847488line22>
> >
> > This patch in general seems to trigger the issue fixed in https://reviews.apache.org/r/63622/. Could you move that one before this patch to keep all patches compilable.
>
> Benjamin Bannier wrote:
> I meant https://reviews.apache.org/r/62444/ of course.
Isn't it already in this order? According to reviewboard, /r/62444 depends on this one.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/#review190316
-----------------------------------------------------------
On Oct. 6, 2017, 2:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62161/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 2:02 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update boost version.
>
>
> Diffs
> -----
>
> 3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
> 3rdparty/boost-1.65.0.tar.gz PRE-CREATION
> 3rdparty/cmake/Versions.cmake 958629642
> 3rdparty/versions.am 82d66be7d
>
>
> Diff: https://reviews.apache.org/r/62161/diff/4/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> 0001-Update-boost-version.patch
> https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62161: Update boost version.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/#review190316
-----------------------------------------------------------
3rdparty/versions.am
Line 22 (original), 22 (patched)
<https://reviews.apache.org/r/62161/#comment267603>
This patch in general seems to trigger the issue fixed in https://reviews.apache.org/r/63622/. Could you move that one before this patch to keep all patches compilable.
- Benjamin Bannier
On Oct. 6, 2017, 4:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62161/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 4:02 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update boost version.
>
>
> Diffs
> -----
>
> 3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
> 3rdparty/boost-1.65.0.tar.gz PRE-CREATION
> 3rdparty/cmake/Versions.cmake 958629642
> 3rdparty/versions.am 82d66be7d
>
>
> Diff: https://reviews.apache.org/r/62161/diff/4/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> 0001-Update-boost-version.patch
> https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62161: Updated boost version.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 4:09 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Rebased onto latest master; fixed order of commits.
Summary (updated)
-----------------
Updated boost version.
Repository: mesos
Description (updated)
-------
Updated boost version.
Diffs (updated)
-----
3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
3rdparty/boost-1.65.0.tar.gz PRE-CREATION
3rdparty/cmake/Versions.cmake ce6ecf5f37613be464153f89f1b6e77155673855
3rdparty/versions.am bd3553396334a1f1ac3a6958088fbf9988f915f3
Diff: https://reviews.apache.org/r/62161/diff/5/
Changes: https://reviews.apache.org/r/62161/diff/4-5/
Testing
-------
File Attachments
----------------
0001-Update-boost-version.patch
https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
Thanks,
Benno Evers
Re: Review Request 62161: Update boost version.
Posted by Benno Evers <be...@mesosphere.com>.
> On Nov. 7, 2017, 3:14 p.m., Benjamin Bannier wrote:
> > 3rdparty/cmake/Versions.cmake
> > Lines 1-2 (original), 1-2 (patched)
> > <https://reviews.apache.org/r/62161/diff/3/?file=1832079#file1832079line1>
> >
> > Let's please make sure to add this bundle to https://github.com/mesos/3rdparty before landing this patch. Otherwise we break cmake builds with `REBUNDLED=OFF`.
https://github.com/mesos/3rdparty/pull/14
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/#review190302
-----------------------------------------------------------
On Oct. 6, 2017, 2:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62161/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 2:02 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update boost version.
>
>
> Diffs
> -----
>
> 3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
> 3rdparty/boost-1.65.0.tar.gz PRE-CREATION
> 3rdparty/cmake/Versions.cmake 958629642
> 3rdparty/versions.am 82d66be7d
>
>
> Diff: https://reviews.apache.org/r/62161/diff/4/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> 0001-Update-boost-version.patch
> https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62161: Update boost version.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Nov. 7, 2017, 7:14 a.m., Benjamin Bannier wrote:
> > 3rdparty/cmake/Versions.cmake
> > Lines 1-2 (original), 1-2 (patched)
> > <https://reviews.apache.org/r/62161/diff/3/?file=1832079#file1832079line1>
> >
> > Let's please make sure to add this bundle to https://github.com/mesos/3rdparty before landing this patch. Otherwise we break cmake builds with `REBUNDLED=OFF`.
>
> Benno Evers wrote:
> https://github.com/mesos/3rdparty/pull/14
Added.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/#review190302
-----------------------------------------------------------
On Oct. 6, 2017, 7:02 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62161/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 7:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update boost version.
>
>
> Diffs
> -----
>
> 3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
> 3rdparty/boost-1.65.0.tar.gz PRE-CREATION
> 3rdparty/cmake/Versions.cmake 958629642
> 3rdparty/versions.am 82d66be7d
>
>
> Diff: https://reviews.apache.org/r/62161/diff/4/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> 0001-Update-boost-version.patch
> https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 62161: Update boost version.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/#review190302
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/cmake/Versions.cmake
Lines 1-2 (original), 1-2 (patched)
<https://reviews.apache.org/r/62161/#comment267593>
Let's please make sure to add this bundle to https://github.com/mesos/3rdparty before landing this patch. Otherwise we break cmake builds with `REBUNDLED=OFF`.
- Benjamin Bannier
On Oct. 6, 2017, 4:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62161/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2017, 4:02 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update boost version.
>
>
> Diffs
> -----
>
> 3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab
> 3rdparty/boost-1.65.0.tar.gz PRE-CREATION
> 3rdparty/cmake/Versions.cmake 958629642
> 3rdparty/versions.am 82d66be7d
>
>
> Diff: https://reviews.apache.org/r/62161/diff/4/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> 0001-Update-boost-version.patch
> https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
>
>
> Thanks,
>
> Benno Evers
>
>