You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/14 19:54:54 UTC
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15224
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
[test] fix flake in TsTabletManagerITest::TestTableStats
In rare cases, leader replica of a tablet can change its role prior to
receiving StepDown request, so the test outputs somelike like:
I0214 18:13:07.095886 5028 raft_consensus.cc:572] T a32ee1063340424db8a7e7ea6aedcfa1 P ddfa34be67fd4a40b26218185403580c [term 3 FOLLOWER]: Rejecting request to step down while not leader
src/kudu/integration-tests/ts_tablet_manager-itest.cc:818: Failure
Failed
Bad status: Illegal state: Code NOT_THE_LEADER: Not currently leader
To avoid test flakiness it makes sense to continue with next tablet
when observing such an error.
Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15224/1
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15224
to look at the new patch set (#4).
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
[test] fix flake in TsTabletManagerITest::TestTableStats
Sometimes the leader replica of a tablet can change its role prior to
receiving StepDown request, so the test outputs somelike like:
I0214 18:13:07.095886 5028 raft_consensus.cc:572] T a32ee1063340424db8a7e7ea6aedcfa1 P ddfa34be67fd4a40b26218185403580c [term 3 FOLLOWER]: Rejecting request to step down while not leader
src/kudu/integration-tests/ts_tablet_manager-itest.cc:818: Failure
Failed
Bad status: Illegal state: Code NOT_THE_LEADER: Not currently leader
To avoid test flakiness it makes sense to continue with next tablet
when observing such an error.
To verify the fix, I ran the scenario in TSAN configuration with and
without this patch:
before: 16 NOT_THE_LEADER failures in 256 runs
after: 0 NOT_THE_LEADER failures in 256 runs
Note, however: even after one source of flakiness is gone, this scenario
is still very flaky.
In addition, I revised other tests where LeaderStepDown() might fail
due to fluctuating leadership and updated them accordingly.
Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
---
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
5 files changed, 75 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15224/4
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
[test] fix flake in TsTabletManagerITest::TestTableStats
Sometimes the leader replica of a tablet can change its role prior to
receiving StepDown request, so the test outputs somelike like:
I0214 18:13:07.095886 5028 raft_consensus.cc:572] T a32ee1063340424db8a7e7ea6aedcfa1 P ddfa34be67fd4a40b26218185403580c [term 3 FOLLOWER]: Rejecting request to step down while not leader
src/kudu/integration-tests/ts_tablet_manager-itest.cc:818: Failure
Failed
Bad status: Illegal state: Code NOT_THE_LEADER: Not currently leader
To avoid test flakiness it makes sense to continue with next tablet
when observing such an error.
To verify the fix, I ran the scenario in TSAN configuration with and
without this patch:
before: 16 NOT_THE_LEADER failures in 256 runs
after: 0 NOT_THE_LEADER failures in 256 runs
Note, however: even after one source of flakiness is gone, this scenario
is still very flaky.
In addition, I revised other tests where LeaderStepDown() might fail
due to fluctuating leadership and updated them accordingly.
Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Reviewed-on: http://gerrit.cloudera.org:8080/15224
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
5 files changed, 75 insertions(+), 32 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Patch Set 3: Verified+1
unrelated test failure: HmsSentryConfigurations/MasterFailoverTest.TestMasterPermanentFailure/0
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 Feb 2020 21:10:02 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@820
PS3, Line 820: auto s = LeaderStepDown(tserver, replica->tablet_id(),
> I wonder how pervasive this issue is amongst our tests. Seems like every AS
Yep, it's a good call. I also thought about this and it seems in several tests it's an issue. In some places ASSERT_EVENTUALLY() would help, in others (line this one) something else should be done.
I was not sure we want to address all such cases in this patch, but why not? :)
I'll post an update re-visiting other places with LeaderStepDown() as well.
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@826
PS3, Line 826: anymor
> anymore
Done
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@829
PS3, Line 829: }
> Do you want to ASSERT_OK(s) after this if statement? And do you still want
Whoops, indeed. Good catch: it seems the line with SleepFor() was accidentally removed.
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 15 Feb 2020 03:53:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15224
to look at the new patch set (#5).
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
[test] fix flake in TsTabletManagerITest::TestTableStats
Sometimes the leader replica of a tablet can change its role prior to
receiving StepDown request, so the test outputs somelike like:
I0214 18:13:07.095886 5028 raft_consensus.cc:572] T a32ee1063340424db8a7e7ea6aedcfa1 P ddfa34be67fd4a40b26218185403580c [term 3 FOLLOWER]: Rejecting request to step down while not leader
src/kudu/integration-tests/ts_tablet_manager-itest.cc:818: Failure
Failed
Bad status: Illegal state: Code NOT_THE_LEADER: Not currently leader
To avoid test flakiness it makes sense to continue with next tablet
when observing such an error.
To verify the fix, I ran the scenario in TSAN configuration with and
without this patch:
before: 16 NOT_THE_LEADER failures in 256 runs
after: 0 NOT_THE_LEADER failures in 256 runs
Note, however: even after one source of flakiness is gone, this scenario
is still very flaky.
In addition, I revised other tests where LeaderStepDown() might fail
due to fluctuating leadership and updated them accordingly.
Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
---
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
5 files changed, 75 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15224/5
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1100
PS4, Line 1100: !s.ok() &&
> Don't need.
Done
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@824
PS4, Line 824: !s.ok() && s.IsIllegalState()
> This is duplicative; the test on s.IsIllegalState() is sufficient.
Done
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@828
PS4, Line 828: continue;
> Do we want to CheckStats here too? Or do so after waiting for kMaxElectionT
If the idea of this scope is checking stats after each election, probably we could do it. However, the idea behind this patch was simply to skip the rare case when the behavior is not of the expected one. From that perspective, I don't think calling CheckStats() is necessary here.
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Feb 2020 03:52:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15224
to look at the new patch set (#3).
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
[test] fix flake in TsTabletManagerITest::TestTableStats
In rare cases, leader replica of a tablet can change its role prior to
receiving StepDown request, so the test outputs somelike like:
I0214 18:13:07.095886 5028 raft_consensus.cc:572] T a32ee1063340424db8a7e7ea6aedcfa1 P ddfa34be67fd4a40b26218185403580c [term 3 FOLLOWER]: Rejecting request to step down while not leader
src/kudu/integration-tests/ts_tablet_manager-itest.cc:818: Failure
Failed
Bad status: Illegal state: Code NOT_THE_LEADER: Not currently leader
To avoid test flakiness it makes sense to continue with next tablet
when observing such an error.
To verify the fix, I ran the scenario in TSAN configuration with and
without this patch:
before: 16 failures in 256 runs
after: 0 failures in 256 runs
Note, however, that this scenario is still incredibly flaky, but
at least one source of flakiness is gone.
Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15224/3
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15224
to look at the new patch set (#2).
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
[test] fix flake in TsTabletManagerITest::TestTableStats
In rare cases, leader replica of a tablet can change its role prior to
receiving StepDown request, so the test outputs somelike like:
I0214 18:13:07.095886 5028 raft_consensus.cc:572] T a32ee1063340424db8a7e7ea6aedcfa1 P ddfa34be67fd4a40b26218185403580c [term 3 FOLLOWER]: Rejecting request to step down while not leader
src/kudu/integration-tests/ts_tablet_manager-itest.cc:818: Failure
Failed
Bad status: Illegal state: Code NOT_THE_LEADER: Not currently leader
To avoid test flakiness it makes sense to continue with next tablet
when observing such an error.
To verify the fix, I ran the scenario in TSAN configuration before
with and without this patch:
before: 16 failures in 256 runs
after: 0 failures in 256 runs
Note, however, that this scenario is still incredibly flaky, but
at least one source of flakiness is gone.
Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15224/2
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Patch Set 5:
Thank you for the review!
Some extra info: I ran the scenario with CheckStats() even when LeaderStepDown() returned NOT_THE_LEADER error -- it works as well, of course. I think just skipping to the next iteration in such case is a good option (that's what this patch now does), but we can always get back and switch to running CheckStats() instead of 'continue', if needed.
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Feb 2020 19:08:46 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@820
PS3, Line 820: auto s = LeaderStepDown(tserver, replica->tablet_id(),
I wonder how pervasive this issue is amongst our tests. Seems like every ASSERT_OK(LeaderStepDown(current_leader, ...)) could be flaky if it's not wrapped in an ASSERT_EVENTUALLY or if it doesn't otherwise allow for the possibility that leadership changed in between when current_leader was populated and now.
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@826
PS3, Line 826: anymor
anymore
http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@829
PS3, Line 829: }
Do you want to ASSERT_OK(s) after this if statement? And do you still want to sleep after the call?
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 Feb 2020 21:28:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1100
PS4, Line 1100: !s.ok() &&
Don't need.
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@824
PS4, Line 824: !s.ok() && s.IsIllegalState()
This is duplicative; the test on s.IsIllegalState() is sufficient.
http://gerrit.cloudera.org:8080/#/c/15224/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@828
PS4, Line 828: continue;
Do we want to CheckStats here too? Or do so after waiting for kMaxElectionTime (which I presume we do to allow for a new leader to be elected somewhere)?
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Feb 2020 01:27:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix flake in TsTabletManagerITest::TestTableStats
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Feb 2020 17:49:44 +0000
Gerrit-HasComments: No