You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TanaseButcaru <gi...@git.apache.org> on 2016/02/16 14:58:00 UTC

[GitHub] cordova-plugin-media-capture pull request: new MediaFile() - fix w...

GitHub user TanaseButcaru opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/54

    new MediaFile() - fix wrong property name for localURL

    If manually created a ``MediaFile`` object and calling ``getFormatData`` on it, it will run into an error with code 2 (invalid argument).
    
    ``MediaFile`` extens the ``File`` constructor, which does not have a ``filePath`` property.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TanaseButcaru/cordova-plugin-media-capture-unofficial newMediaFile-localURL-prop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #54
    
----
commit ed307cf165ee9df8a8f37abaa92cba87afe61d31
Author: TanaseButcaru <co...@butcaru.com>
Date:   2016-02-16T13:54:02Z

    new MediaFile() - fix wrong property name for localURL

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-media-capture pull request: new MediaFile() - fix w...

Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/54#issuecomment-218629194
  
    Cordova CI Build has one or more failures. 
    
    **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1/
    
    **Results**
    1. [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-store/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-store/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-store/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-store/artifact/)
    2. [Windows 10  Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//80/label=windows-slave,platformName=windows-10-store/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-10-store/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-10-store/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-10-store/artifact/)
    3. [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-phone/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-phone/) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-phone/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=windows-8.1-phone/artifact/)
    4. [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=ios/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=ios/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=ios/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=ios/artifact/)
    5. [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=android/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=android/) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=android/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=mac-slave,platformName=android/artifact/)
    6. [Android Windows]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=android/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=android/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=android/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1//label=windows-slave,platformName=android/artifact/)
    
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org