You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/18 14:20:31 UTC
[GitHub] [spark] tgravescs commented on pull request #36208: [SPARK-38911][CORE] Fix the potential resource profile id mess up issue
tgravescs commented on PR #36208:
URL: https://github.com/apache/spark/pull/36208#issuecomment-1101446496
I remember this type of scenario coming up when writing/reviewing this and can't remember all the detail but I think it came down we don't expect people to be creating it before SparkContext so punt on that until someone really requested it. I think I considered creating a special api for the default profile but seems like extra if wasn't really required. We should at least check though before stomping over an existing one with same id and throw saying to create them after the SparkContext initialized.
I guess unless we have a real use case this is required to create before SparkContext, I'd rather see us update the getOrCreateDefaultProfile to check to see if its in use and if so throw and then just update the test to make sure its initialized.
if its truly required we should spend the time to do it correctly and not skip ids, which I think could just be potentially confusing to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org