You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/11/28 19:45:44 UTC
Review Request 28529: Extract HTTPS_Manager and JDK_manager classes
from ambari-server.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-8475
https://issues.apache.org/jira/browse/AMBARI-8475
Repository: ambari
Description
-------
Diffs
-----
ambari-server/src/main/python/ambari-server.py fc3b843
ambari-server/src/test/python/TestAmbariServer.py 0eae33b
Diff: https://reviews.apache.org/r/28529/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Florian Barca <fb...@hortonworks.com>.
> On March 16, 2015, 12:43 p.m., Nate Cole wrote:
> > What is the status of this code? Has this already been abstracted?
Not literally, but a lot of code has been moved out into separate files. See https://hortonworks.jira.com/browse/BUG-29087. The current patch will likely not apply.
- Florian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review76550
-----------------------------------------------------------
On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 6:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review76550
-----------------------------------------------------------
What is the status of this code? Has this already been abstracted?
- Nate Cole
On Nov. 28, 2014, 1:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 1:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review85858
-----------------------------------------------------------
Please close this review, it's 6 months old.
- Nate Cole
On Nov. 28, 2014, 1:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 1:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
> On Dec. 2, 2014, 4:49 p.m., Nate Cole wrote:
> > I agree with Dmitro Lisnichenko. There is the directory a-s/src/main/python/ambari_server that these new classes can be moved to. That helps a lot to cut down on the cruft in ambari-server.py.
Nate, please see main jira "should not show traceback on exception during setup". There are a lot of other classes (sub tasks) which should be extracted. I just want to do this step by step to provide more often code integration. Ends up, all extracted classes can be moved to separate files. Common, for all changes, patch will be to big and difficult for review. So I have divided main jira to small subtasks.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review63546
-----------------------------------------------------------
On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 6:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
> On Dec. 2, 2014, 4:49 p.m., Nate Cole wrote:
> > I agree with Dmitro Lisnichenko. There is the directory a-s/src/main/python/ambari_server that these new classes can be moved to. That helps a lot to cut down on the cruft in ambari-server.py.
>
> Dmytro Shkvyra wrote:
> Nate, please see main jira "should not show traceback on exception during setup". There are a lot of other classes (sub tasks) which should be extracted. I just want to do this step by step to provide more often code integration. Ends up, all extracted classes can be moved to separate files. Common, for all changes, patch will be to big and difficult for review. So I have divided main jira to small subtasks.
Ok. I'll provide common path for all my changes.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review63546
-----------------------------------------------------------
On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 6:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review63546
-----------------------------------------------------------
I agree with Dmitro Lisnichenko. There is the directory a-s/src/main/python/ambari_server that these new classes can be moved to. That helps a lot to cut down on the cruft in ambari-server.py.
- Nate Cole
On Nov. 28, 2014, 1:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 1:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
> On Dec. 1, 2014, 12:44 p.m., Dmitro Lisnichenko wrote:
> > As I understand the idea of this jira, classes (and tests for them) should be moved to separate files since ambari-server.py is getting too large?
No, the main idea is separate functionality of ambari-server.py to classes but we do not need separate it to different files. I have to separate functionality, because in case of main task ("should not show traceback on exception during setup") we cant fix unitests. Earlier, I have extracted firewall class as file, but it was need because we had duplacates of this code in server and agent. In this case we will not reuse code, but we have "spagetti code" which we cant test in normal way.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review63352
-----------------------------------------------------------
On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 6:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review63352
-----------------------------------------------------------
As I understand the idea of this jira, classes (and tests for them) should be moved to separate files since ambari-server.py is getting too large?
- Dmitro Lisnichenko
On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 6:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review63394
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 6:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28529: Extract HTTPS_Manager and JDK_manager
classes from ambari-server.py
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/
-----------------------------------------------------------
(Updated Nov. 28, 2014, 6:46 p.m.)
Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
Bugs: AMBARI-8475
https://issues.apache.org/jira/browse/AMBARI-8475
Repository: ambari
Description (updated)
-------
Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
Diffs
-----
ambari-server/src/main/python/ambari-server.py fc3b843
ambari-server/src/test/python/TestAmbariServer.py 0eae33b
Diff: https://reviews.apache.org/r/28529/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk