You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (JIRA)" <ji...@apache.org> on 2018/11/09 06:27:00 UTC

[jira] [Resolved] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

     [ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konrad Windszus resolved SLING-8084.
------------------------------------
    Resolution: Fixed

Fixed with https://github.com/apache/sling-org-apache-sling-api/commit/aaf0a43dd7fe8d80861579b2744b045cbd6cd2e2.

> Clarify javadoc for ResourceResolver.map(...)
> ---------------------------------------------
>
>                 Key: SLING-8084
>                 URL: https://issues.apache.org/jira/browse/SLING-8084
>             Project: Sling
>          Issue Type: Bug
>          Components: API
>    Affects Versions: API 2.18.4
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: API 2.18.6
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}} (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283) does not clearly state whether URI encoding is done within or not.
> If I understand https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160 and https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362 correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in a row might lead to a 404 in the end.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)