[GitHub] [knox] pzampino commented on a change in pull request #250: KNOX-2209 - Improve logging for Knox token handling

[GitBox <gi...@apache.org>]

pzampino commented on a change in pull request #250: KNOX-2209 - Improve logging for Knox token handling
URL: https://github.com/apache/knox/pull/250#discussion_r373619768
 
 

 ##########
 File path: gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
 ##########
 @@ -384,4 +391,9 @@ private long getExpiry() {
     }
     return expiry;
   }
+
+  private String getTopologyName() {
+    return (String) context.getAttribute("org.apache.knox.gateway.gateway.cluster");
 
 Review comment:
   This is why I put it in a method that makes it more clear (aside from the obvious benefit of re-use). I can create a constant for it. Are you suggesting a constant in this class, or somewhere else for broader consumption?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services