[GitHub] [arrow] save-buffer commented on a diff in pull request #14225: ARROW-17836: [C++] Allow specifying alignment of buffers

[GitBox <gi...@apache.org>]

save-buffer commented on code in PR #14225:
URL: https://github.com/apache/arrow/pull/14225#discussion_r1024650356


##########
cpp/src/arrow/array/builder_base.h:
##########
@@ -69,7 +69,8 @@ constexpr int64_t kListMaximumElements = std::numeric_limits<int32_t>::max() - 1
 /// For example, ArrayBuilder* pointing to BinaryBuilder should be downcast before use.
 class ARROW_EXPORT ArrayBuilder {
  public:
-  explicit ArrayBuilder(MemoryPool* pool) : pool_(pool), null_bitmap_builder_(pool) {}
+  explicit ArrayBuilder(MemoryPool* pool, int64_t alignment = kDefaultBufferAlignment)
+      : pool_(pool), alignment_(alignment), null_bitmap_builder_(pool) {}

Review Comment:
   Good catch, we probably do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org