You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/06/07 14:38:48 UTC

[GitHub] [mynewt-core] sterlinghughes commented on a change in pull request #1867: Add back K380 speed to nrf52xxx hal_i2c

sterlinghughes commented on a change in pull request #1867: Add back K380 speed to nrf52xxx hal_i2c
URL: https://github.com/apache/mynewt-core/pull/1867#discussion_r291621580
 
 

 ##########
 File path: hw/mcu/nordic/src/ext/nrfx/mdk/nrf52_bitfields.h
 ##########
 @@ -11169,6 +11169,7 @@ POSSIBILITY OF SUCH DAMAGE.
 #define TWI_FREQUENCY_FREQUENCY_Msk (0xFFFFFFFFUL << TWI_FREQUENCY_FREQUENCY_Pos) /*!< Bit mask of FREQUENCY field. */
 #define TWI_FREQUENCY_FREQUENCY_K100 (0x01980000UL) /*!< 100 kbps */
 #define TWI_FREQUENCY_FREQUENCY_K250 (0x04000000UL) /*!< 250 kbps */
+#define TWI_FREQUENCY_FREQUENCY_K380 (0x06147ae9UL) /*!< 380 kbps */
 
 Review comment:
   I think we should add this to i2c_nrf52_twim.c, rather than maintain a custom patched NRFX library.  I don't see usage of this anywhere but in that driver, is that correct? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services