You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/27 14:15:30 UTC

[GitHub] [tvm] leandron commented on a change in pull request #7350: [BYOC][VitisAI] Fix issue in Vitis AI codegen out tensor names matching & update docs and docker

leandron commented on a change in pull request #7350:
URL: https://github.com/apache/tvm/pull/7350#discussion_r565340201



##########
File path: docker/Dockerfile.demo_vitis_ai
##########
@@ -18,7 +18,7 @@
 # CI docker VAI env
 FROM xilinx/vitis-ai:latest
 
-RUN apt-get update --fix-missing
+RUN apt-get update --fix-missing && apt-get install -y gpg-agent

Review comment:
       To save same space on your image, Docker recommends a little boilerplate when using `apt-get`. I suggest adding that recommended `&& rm -rf /var/lib/apt/lists/*` in the end here.
   
   You can read about it here: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org