You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/12 11:31:25 UTC

[GitHub] [arrow-rs] waitingkuo commented on a diff in pull request #3088: Improved UX of creating `TimestampNanosecondArray` with timezones

waitingkuo commented on code in PR #3088:
URL: https://github.com/apache/arrow-rs/pull/3088#discussion_r1020749749


##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -779,8 +779,13 @@ impl<T: ArrowTimestampType> PrimitiveArray<T> {
     }
 
     /// Construct a timestamp array with new timezone
-    pub fn with_timezone(&self, timezone: String) -> Self {
-        self.with_timezone_opt(Some(timezone))
+    pub fn with_timezone(&self, timezone: impl Into<String>) -> Self {

Review Comment:
   Thank you @src255 @alamb 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org