You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2019/05/09 07:24:43 UTC

[GitHub] [wicket] andruhon commented on a change in pull request #359: Wicket js cleanup

andruhon commented on a change in pull request #359: Wicket js cleanup
URL: https://github.com/apache/wicket/pull/359#discussion_r282364806
 
 

 ##########
 File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
 ##########
 @@ -1143,23 +1085,9 @@
 
 				e.style.zIndex = Wicket.Window.Mask.zIndex;
 
 Review comment:
   I believe that dodgy HTML in getMarkup at LL981-1041 can also be heavily simplified. I think it was done that complex to make it drop shadow made from images, which is unnecessary in 2019, because support for browsers without `box-shadow` has dropped a while ago. I can do this refactoring later to make it look nicer as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services