You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "DheerajKumar19 (via GitHub)" <gi...@apache.org> on 2023/05/15 08:12:33 UTC

[GitHub] [fineract] DheerajKumar19 opened a new pull request, #3180: FINERACT-1013: Fixed validation of boolean input values

DheerajKumar19 opened a new pull request, #3180:
URL: https://github.com/apache/fineract/pull/3180

   ## Description
   Implemented the changes mentioned in the ticket FINERACT-1013
   ## Potential PR improvements
   
   - Adding Unit tests.
   
   - If the changes look right will be implementing the same in the below classes 
   1. GlobalConfigurationDataValidator
   2. LoanProductDataValidator
   3. DepositAccountDataValidator
   4. UserDataValidator
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   
   
   @ptuomola Can you please review this PR and let me know if any changes is needed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] closed pull request #3180: FINERACT-1013: Fixed validation of boolean input values

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3180: FINERACT-1013: Fixed validation of boolean input values
URL: https://github.com/apache/fineract/pull/3180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] commented on pull request #3180: FINERACT-1013: Fixed validation of boolean input values

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3180:
URL: https://github.com/apache/fineract/pull/3180#issuecomment-1666650194

   This pull request seems to be stale.  Are you still planning to work on it?  We will automatically close it in 30 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] DheerajKumar19 commented on pull request #3180: FINERACT-1013: Fixed validation of boolean input values

Posted by "DheerajKumar19 (via GitHub)" <gi...@apache.org>.
DheerajKumar19 commented on PR #3180:
URL: https://github.com/apache/fineract/pull/3180#issuecomment-1592161867

   Yes I am still planning to work on this and add a few Test cases to cover the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] commented on pull request #3180: FINERACT-1013: Fixed validation of boolean input values

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3180:
URL: https://github.com/apache/fineract/pull/3180#issuecomment-1592152484

   This pull request seems to be stale.  Are you still planning to work on it?  We will automatically close it in 30 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics commented on pull request #3180: FINERACT-1013: Fixed validation of boolean input values

Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #3180:
URL: https://github.com/apache/fineract/pull/3180#issuecomment-1623680652

   @DheerajKumar19 please add them then. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org