You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov> on 2014/04/30 18:20:51 UTC

Re: svn commit: r1591385 - /oodt/trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/DataSourceMetExtractor.java

woot was going to comment you beat me to it! :)



-----Original Message-----
From: "bfoster@apache.org" <bf...@apache.org>
Reply-To: "dev@oodt.apache.org" <de...@oodt.apache.org>
Date: Wednesday, April 30, 2014 11:18 AM
To: "commits@oodt.apache.org" <co...@oodt.apache.org>
Subject: svn commit: r1591385 -
/oodt/trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/
DataSourceMetExtractor.java

>Author: bfoster
>Date: Wed Apr 30 16:18:40 2014
>New Revision: 1591385
>
>URL: http://svn.apache.org/r1591385
>Log:
>- nvm ... DatabaseConnectionBuilder.buildDataSource does this already
>
>Modified:
>    
>oodt/trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/
>DataSourceMetExtractor.java
>
>Modified: 
>oodt/trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/
>DataSourceMetExtractor.java
>URL: 
>http://svn.apache.org/viewvc/oodt/trunk/metadata/src/main/java/org/apache/
>oodt/cas/metadata/extractors/DataSourceMetExtractor.java?rev=1591385&r1=15
>91384&r2=1591385&view=diff
>==========================================================================
>====
>--- 
>oodt/trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/
>DataSourceMetExtractor.java (original)
>+++ 
>oodt/trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/
>DataSourceMetExtractor.java Wed Apr 30 16:18:40 2014
>@@ -54,7 +54,6 @@ public class DataSourceMetExtractor exte
>   protected Metadata extrMetadata(File file) throws
>MetExtractionException {
>     String key = getKey(file);
>     DataSourceMetExtractorConfig dsConfig =
>(DataSourceMetExtractorConfig) config;
>-    insureLoadDriver(dsConfig.getDriver());
>     DataSource dataSource =
>DatabaseConnectionBuilder.buildDataSource(dsConfig.getUserName(),
>         dsConfig.getPassword(), dsConfig.getDriver(),
>dsConfig.getDatabaseUrl());
> 
>@@ -100,12 +99,4 @@ public class DataSourceMetExtractor exte
>     }
>     return metadata;
>   }
>-  
>-  private void insureLoadDriver(String driver) throws
>MetExtractionException {
>-    try {
>-      Class.forName(driver);
>-    } catch (ClassNotFoundException e) {
>-      throw new MetExtractionException("Failed to load driver: " +
>driver, e);
>-    }
>-  }
> }
>
>