[GitHub] [superset] john-bodley commented on a diff in pull request #24324: chore: rate limit requests

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24324:
URL: https://github.com/apache/superset/pull/24324#discussion_r1224560484


##########
superset/models/dashboard.py:
##########
@@ -382,7 +382,7 @@ def export_dashboards(  # pylint: disable=too-many-locals
     ) -> str:
         copied_dashboards = []
         datasource_ids = set()
-        for dashboard_id in dashboard_ids:
+        for dashboard_id in set(dashboard_ids):

Review Comment:
   If there's an issue with duplicates—where order doesn't matter—is there merit in changing the `export_dashboards` method to have `dashboard_ids` as `set[int]`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org