[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1616: Seperate Action Implementations into Spark Specific Modules - With Reflection

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #1616:
URL: https://github.com/apache/iceberg/pull/1616#discussion_r506523695



##########
File path: spark/src/main/java/org/apache/iceberg/actions/Actions.java
##########
@@ -19,25 +19,57 @@
 
 package org.apache.iceberg.actions;
 
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
 import org.apache.iceberg.Table;
 import org.apache.spark.sql.SparkSession;
 
 public class Actions {
+  private static final String IMPL_NAME = "SparkActions";
+
+  private static Class<Actions> implClass;
+  private static Constructor<Actions> implConstructor;
 
   private SparkSession spark;
   private Table table;
 
-  private Actions(SparkSession spark, Table table) {
+  protected Actions(SparkSession spark, Table table) {
     this.spark = spark;
     this.table = table;
   }
 
+  private static Constructor actionConstructor() {

Review comment:
       Unfortunately DynConstructor wraps up exceptions (no explicit throws) a bit differently so we can't just catch a NSME, let me see if I can do something similar.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org