You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zuotingbing <gi...@git.apache.org> on 2017/03/31 11:01:36 UTC
[GitHub] spark pull request #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullP...
GitHub user zuotingbing opened a pull request:
https://github.com/apache/spark/pull/17496
[SPARK-20173][SQL][hive-thriftserver] Throw NullPointerException when HiveThriftServer2 is shutdown
## What changes were proposed in this pull request?
Throw NullPointerException when HiveThriftServer2 is shutdown
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuotingbing/spark SPARK-HiveThriftServer2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17496
----
commit 47a81dcadedcac01cf05eddfbb4a7aa7bf1c3d38
Author: zuotingbing <zu...@zte.com.cn>
Date: 2017-03-31T10:56:01Z
[SPARK-20173][SQL] Throw NullPointerException when HiveThriftServer2 is shutdown
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullP...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17496
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullP...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17496#discussion_r109137993
--- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala ---
@@ -82,7 +82,9 @@ object HiveThriftServer2 extends Logging {
ShutdownHookManager.addShutdownHook { () =>
SparkSQLEnv.stop()
- uiTab.foreach(_.detach())
+ if (uiTab != null) {
+ uiTab.foreach(_.detach())
--- End diff --
Yes of course.
OK, i'll change it as you suggested. Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullPointerE...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17496
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullPointerE...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17496
**[Test build #3630 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3630/testReport)** for PR 17496 at commit [`5ae5f4d`](https://github.com/apache/spark/commit/5ae5f4d02fb279450dbac800d38aa5417bac66f8).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullP...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17496#discussion_r109137114
--- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala ---
@@ -82,7 +82,9 @@ object HiveThriftServer2 extends Logging {
ShutdownHookManager.addShutdownHook { () =>
SparkSQLEnv.stop()
- uiTab.foreach(_.detach())
+ if (uiTab != null) {
+ uiTab.foreach(_.detach())
--- End diff --
I think it's easier to just init the Option to None instead of `_` which is null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullPointerE...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17496
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17496: [SPARK-20173][SQL][hive-thriftserver] Throw NullPointerE...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17496
**[Test build #3630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3630/testReport)** for PR 17496 at commit [`5ae5f4d`](https://github.com/apache/spark/commit/5ae5f4d02fb279450dbac800d38aa5417bac66f8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org