[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release

[GitBox <gi...@apache.org>]

gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534035254



##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 1.16.0
+appVersion: 2.1.0
+
+dependencies:
+  - name: etcd
+    version: 5.2.1

Review comment:
       This is etcd Charts version ，not the version of etcd.
   It is Chart dependencies here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org