You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2010/11/24 00:08:10 UTC
svn commit: r1038371 [2/2] - in /wicket/trunk:
wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/
wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/
wicket-examples/src/main/java/org/apache/wicket/examples/ajax/bu...
Modified: wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/PageAccessSynchronizerTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/PageAccessSynchronizerTest.java?rev=1038371&r1=1038370&r2=1038371&view=diff
==============================================================================
--- wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/PageAccessSynchronizerTest.java (original)
+++ wicket/trunk/wicket/src/test/java/org/apache/wicket/pageStore/PageAccessSynchronizerTest.java Tue Nov 23 23:08:06 2010
@@ -215,9 +215,9 @@ public class PageAccessSynchronizerTest
bots[i].start();
}
- for (int i = 0; i < bots.length; i++)
+ for (Worker bot : bots)
{
- bots[i].join();
+ bot.join();
}
monitor.stop = true;
Modified: wicket/trunk/wicket/src/test/java/org/apache/wicket/util/string/StringsTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/util/string/StringsTest.java?rev=1038371&r1=1038370&r2=1038371&view=diff
==============================================================================
--- wicket/trunk/wicket/src/test/java/org/apache/wicket/util/string/StringsTest.java (original)
+++ wicket/trunk/wicket/src/test/java/org/apache/wicket/util/string/StringsTest.java Tue Nov 23 23:08:06 2010
@@ -477,10 +477,10 @@ public final class StringsTest extends T
{
AppendingStringBuffer sb = new AppendingStringBuffer("[");
String komma = "";
- for (int i = 0; i < arrayOfStrings.length; i++)
+ for (String str : arrayOfStrings)
{
sb.append(komma);
- sb.append(arrayOfStrings[i]);
+ sb.append(str);
komma = ",";
}
sb.append("]");
Modified: wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/EmailValidatorTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/EmailValidatorTest.java?rev=1038371&r1=1038370&r2=1038371&view=diff
==============================================================================
--- wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/EmailValidatorTest.java (original)
+++ wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/EmailValidatorTest.java Tue Nov 23 23:08:06 2010
@@ -51,11 +51,9 @@ public class EmailValidatorTest extends
EmailAddressValidator test = new EmailAddressValidator();
String[] emails = new String[] { "b.blaat@topicus.nl", "blaat@hotmail.com",
"1.2.3.4@5.6.7.nl", "m@m.nl", "M@M.NL" };
- for (int i = 0; i < emails.length; i++)
+ for (String email : emails)
{
- assertTrue(emails[i] + " should be valid", test.getPattern()
- .matcher(emails[i])
- .matches());
+ assertTrue(email + " should be valid", test.getPattern().matcher(email).matches());
}
}
@@ -67,11 +65,9 @@ public class EmailValidatorTest extends
EmailAddressValidator test = new EmailAddressValidator();
String[] emails = new String[] { ".blaat@topicus.nl", "blaat.@hotmail.com", "blaat@nl",
"blaat@.nl" };
- for (int i = 0; i < emails.length; i++)
+ for (String email : emails)
{
- assertFalse(emails[i] + " should not be valid", test.getPattern()
- .matcher(emails[i])
- .matches());
+ assertFalse(email + " should not be valid", test.getPattern().matcher(email).matches());
}
}
}
Modified: wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java?rev=1038371&r1=1038370&r2=1038371&view=diff
==============================================================================
--- wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java (original)
+++ wicket/trunk/wicket/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java Tue Nov 23 23:08:06 2010
@@ -77,9 +77,8 @@ public class UrlValidatorTest extends Te
String[] schemes = { "http", "gopher" };
// UrlValidator urlVal = new UrlValidator(schemes,false,false,false);
UrlValidator urlVal = new UrlValidator(schemes, 0);
- for (int sIndex = 0; sIndex < testScheme.length; sIndex++)
+ for (ResultPair testPair : testScheme)
{
- ResultPair testPair = testScheme[sIndex];
boolean result = urlVal.isValidScheme(testPair.item);
assertEquals(testPair.item, testPair.valid, result);
if (printStatus)