[GitHub] spark pull request #22375: [SPARK-25388][Test][SQL] Detect incorrect nullabl...

[mgaido91 <gi...@git.apache.org>]

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22375#discussion_r217381027
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala ---
    @@ -35,6 +36,13 @@ class ExpressionEvalHelperSuite extends SparkFunSuite with ExpressionEvalHelper
         val e = intercept[RuntimeException] { checkEvaluation(BadCodegenExpression(), 10) }
         assert(e.getMessage.contains("some_variable"))
       }
    +
    +  test("SPARK-25388: checkEvaluation should fail if nullable in DataType is incorrect") {
    +    val e = intercept[RuntimeException] {
    +      checkEvaluation(MapIncorrectDataTypeExpression(), Map(3 -> 7, 6 -> null))
    --- End diff --
    
    what happens if here you put `Map(3 -> 7, 6 -> -1)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org