You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2016/10/06 16:19:01 UTC

svn commit: r1763623 - in /qpid/java/trunk: bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/AbstractBDBMessageStore.java broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java

Author: orudyy
Date: Thu Oct  6 16:19:01 2016
New Revision: 1763623

URL: http://svn.apache.org/viewvc?rev=1763623&view=rev
Log:
QPID-7447: [Java Broker] Avoid empty iterator creation on handling of post-commit actions in store transaction

Modified:
    qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/AbstractBDBMessageStore.java
    qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java

Modified: qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/AbstractBDBMessageStore.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/AbstractBDBMessageStore.java?rev=1763623&r1=1763622&r2=1763623&view=diff
==============================================================================
--- qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/AbstractBDBMessageStore.java (original)
+++ qpid/java/trunk/bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/AbstractBDBMessageStore.java Thu Oct  6 16:19:01 2016
@@ -1348,11 +1348,14 @@ public abstract class AbstractBDBMessage
 
         private void doPostCommitActions()
         {
-            for(Runnable action : _postCommitActions)
+            if (!_postCommitActions.isEmpty())
             {
-                action.run();
+                for (Runnable action : _postCommitActions)
+                {
+                    action.run();
+                }
+                _postCommitActions.clear();
             }
-            _postCommitActions.clear();
         }
 
         @Override

Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java?rev=1763623&r1=1763622&r2=1763623&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java Thu Oct  6 16:19:01 2016
@@ -1193,11 +1193,14 @@ public abstract class AbstractJDBCMessag
 
         private void doPostCommitActions()
         {
-            for(Runnable action : _postCommitActions)
+            if (!_postCommitActions.isEmpty())
             {
-                action.run();
+                for (Runnable action : _postCommitActions)
+                {
+                    action.run();
+                }
+                _postCommitActions.clear();
             }
-            _postCommitActions.clear();
         }
 
         @Override



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org