You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2019/05/14 10:52:18 UTC

[GitHub] [sling-org-apache-sling-distribution-journal-kafka] tmaret commented on a change in pull request #5: Sling 8414

tmaret commented on a change in pull request #5: Sling 8414
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka/pull/5#discussion_r283738472
 
 

 ##########
 File path: src/main/java/org/apache/sling/distribution/journal/kafka/KafkaClientProvider.java
 ##########
 @@ -79,6 +79,10 @@
 
     public static final int PARTITION = 0;
 
+    private static final String SECURITY_PROTOCOL = "security.protocol";
 
 Review comment:
   Good point. Those seem to be defined in `org.apache.kafka.common.config.SaslConfigs` (`SASL_MECHANISM` and `SASL_JAAS_CONFIG`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services