You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2025/04/11 00:10:01 UTC
[PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
WillAyd opened a new pull request, #46105:
URL: https://github.com/apache/arrow/pull/46105
### Rationale for this change
Flatbuffers statically requires that the version used to generate the prototypes within the code base is the same version used to compile it. A system install of flatbuffers is therefore highly unlikely to be usable
### What changes are included in this PR?
Removed the system install of flatbuffers on macOS
### Are these changes tested?
In CI
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795466846
@github-actions crossbow submit verify-rc-source-cpp-macos-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795583807
@kou maybe this is viable? Or we should pin the version of flatbuffers used in the Brewfile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795679666
@github-actions crossbow submit verify-rc-source-*-macos-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system Flatbuffers from macOS [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46105:
URL: https://github.com/apache/arrow/pull/46105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795678948
@github-actions crossbow submit verify-rc-source-ruby-macos-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795706478
Right. We're using the vendored approach. So I think that we should use the vendored Flatbuffers even when there is a system Flatbuffers. (I think that it's a real fix.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system Flatbuffers from macOS [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2796441711
@github-actions crossbow submit verify-rc-source-*-macos-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system Flatbuffers from macOS [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2796449407
Revision: b27bf7e2279cdfd04cecc70d06d917f683d4fc9a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-34dfae5216](https://github.com/ursacomputing/crossbow/branches/all?query=actions-34dfae5216)
|Task|Status|
|----|------|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14400646161/job/40385458614)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14400645883/job/40385457689)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14400645947/job/40385457703)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14400646036/job/40385458453)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14400645872/job/40385457744)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14400645868/job/40385457682)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795681357
Revision: b27bf7e2279cdfd04cecc70d06d917f683d4fc9a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-febc5892d7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-febc5892d7)
|Task|Status|
|----|------|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14394180164/job/40366810873)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system Flatbuffers from macOS [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2796412602
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 32641ecfd97e302ea8119b1147d77aced96d097b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/40384959325) has more details. It also includes information about 20 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795690387
I believe flatbuffers requires that the version used to generate the code must be exactly the same version used to compile the code. So from that perspective the Arrow build system dependency should either be vendored, or you would have to ensure your system has the exact same version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795682149
Revision: b27bf7e2279cdfd04cecc70d06d917f683d4fc9a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4c932a1672](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4c932a1672)
|Task|Status|
|----|------|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14394188266/job/40366832559)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14394187991/job/40366832089)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14394188137/job/40366832358)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14394188076/job/40366832251)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14394188136/job/40366832350)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14394188213/job/40366832487)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46067: [CI][C++] Remove system flatbuffers from macOS [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46105:
URL: https://github.com/apache/arrow/pull/46105#issuecomment-2795469418
Revision: b27bf7e2279cdfd04cecc70d06d917f683d4fc9a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4ebe73daec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4ebe73daec)
|Task|Status|
|----|------|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14392692509/job/40362791352)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org