[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8737: Migration and model changes to synchronize the data model

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8737: Migration and model changes to synchronize the data model
URL: https://github.com/apache/incubator-superset/pull/8737#discussion_r356172364
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -347,7 +347,7 @@ class SqlaTable(Model, BaseDatasource):
     owner_class = security_manager.user_model
 
     __tablename__ = "tables"
-    __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+    __table_args__ = (UniqueConstraint("database_id", "schema", "table_name", name="_customer_location_uc"),)
 
 Review comment:
   @john-bodley this change is on the model to bring it in line with the existing constraint at the database layer. Should we instead be adding a migration to remove the existing table constraint? How would you recommend we reconcile the model definitions with the table schema in this instance? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org