You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Simone Tripodi (JIRA)" <ji...@apache.org> on 2011/05/13 11:59:48 UTC
[jira] [Created] (OGNL-9) Upgrade JUnit to version4
Upgrade JUnit to version4
-------------------------
Key: OGNL-9
URL: https://issues.apache.org/jira/browse/OGNL-9
Project: OGNL (Incubating)
Issue Type: Task
Reporter: Simone Tripodi
Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034699#comment-13034699 ]
Hudson commented on OGNL-9:
---------------------------
Integrated in ognl #50 (See [https://builds.apache.org/hudson/job/ognl/50/])
OGNL-9 - Upgrade JUnit to version4
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035090#comment-13035090 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
Patch applied.
What's more this behaviour agrees with the api docs:
{code}
/**
* Finds the best possible match for a method on the specified target class with a matching name.
* <p>
* The name matched will also try different combinations like <code>is + name, has + name, get + name, etc..</code>
* </p>
*
* @param target The class to find a matching method against.
* @param name The name of the method.
* @return The most likely matching {@link Method}, or null if none could be found.
*/
{code}
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: OGNL-9-1.patch, ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034672#comment-13034672 ]
Simone Tripodi commented on OGNL-9:
-----------------------------------
Mau,
can you check please if there are 2 commented tests? Now we have 725 tests, before JUnit4 migration 727.
Just find {{FIXME}} tags inside java sources un tests.
Thanks in advance!
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034686#comment-13034686 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
Thanks Olivier,
It's a good starting point.
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034907#comment-13034907 ]
Maurizio Cucchiara edited comment on OGNL-9 at 5/17/11 5:34 PM:
----------------------------------------------------------------
Olivier,
take a look at the attached patch and tell me WDYT please.
I thought the aside the first match policy, we could add a exactly match approach.
was (Author: maurizio.cucchiara):
Olivier,
take a look at the attached patch please.
I thought the aside the first match policy, we could add a exactly match approach.
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: OGNL-9-1.patch, ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maurizio Cucchiara updated OGNL-9:
----------------------------------
Attachment: OGNL-9-1.patch
Olivier,
take a look at the attached patch please.
I thought the aside the first match policy, we could add a exactly match approach.
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: OGNL-9-1.patch, ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034666#comment-13034666 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
Thank you Oliver to drawn to my attention that. (I thought I broke the trunk :) )
I'll take a look ASAP, maybe there is something wrong with the hudson environment configuration.
You could also consider to ignore the test.
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034685#comment-13034685 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
Ok Simone,
we would came back to 727
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034655#comment-13034655 ]
Simone Tripodi commented on OGNL-9:
-----------------------------------
Kudos Maurizio, great achievement! Congrats!!!
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034646#comment-13034646 ]
Hudson commented on OGNL-9:
---------------------------
Integrated in ognl #46 (See [https://builds.apache.org/hudson/job/ognl/46/])
OGNL-9 Upgrade JUnit to version4
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034088#comment-13034088 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
Hi Simone,
good news! I'm working on it and it's almost done.
Most of the unit test is passing now !
Stay tuned
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034688#comment-13034688 ]
Simone Tripodi commented on OGNL-9:
-----------------------------------
@Maurizio: cool, saw the commit and updated locally, great!
@Olivier: indeed, I'm running the jdk 1.6, that's why they didn't fail :(
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035087#comment-13035087 ]
Hudson commented on OGNL-9:
---------------------------
Integrated in ognl #55 (See [https://builds.apache.org/hudson/job/ognl/55/])
OGNL-9 - Upgrade JUnit to version4 (from now the method name which exactly matches the ognl expression takes the precedence)
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1104581
Files :
* /incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
* /incubator/ognl/trunk/src/test/java/org/apache/commons/ognl/test/CollectionDirectPropertyTest.java
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: OGNL-9-1.patch, ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034689#comment-13034689 ]
Hudson commented on OGNL-9:
---------------------------
Integrated in ognl #49 (See [https://builds.apache.org/hudson/job/ognl/49/])
OGNL-9 - Upgrade JUnit to version4
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034659#comment-13034659 ]
Olivier Lamy commented on OGNL-9:
---------------------------------
this was failing since the beginning.
sure weird :-)
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034668#comment-13034668 ]
Simone Tripodi commented on OGNL-9:
-----------------------------------
my local build successfully ran... :/
{code}
Results :
Tests run: 725, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26.767s
[INFO] Finished at: Tue May 17 11:46:56 CEST 2011
[INFO] Final Memory: 15M/1015M
[INFO] ------------------------------------------------------------------------
{code}
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OGNL-9) Upgrade JUnit to version4
Posted by "Christian Grobmeier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Grobmeier resolved OGNL-9.
------------------------------------
Resolution: Fixed
fixed
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: OGNL-9-1.patch, ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034697#comment-13034697 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
I have commented the failed test, now we should gain a greenbar from Hudson.
I'm investigating still now.
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034904#comment-13034904 ]
Olivier Lamy commented on OGNL-9:
---------------------------------
I wonder if we could simply force reordering of this array before iterate on it with natural alphabetical order.
Just in order to prevent such dependency on the implementation.
?
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034675#comment-13034675 ]
Olivier Lamy commented on OGNL-9:
---------------------------------
note the success with jdk 1.6 (was failing with 1.5)
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034682#comment-13034682 ]
Olivier Lamy commented on OGNL-9:
---------------------------------
k.
fyi jenkins job reconfigured to use 1.5
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034992#comment-13034992 ]
Olivier Lamy commented on OGNL-9:
---------------------------------
+1 souds good !
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: OGNL-9-1.patch, ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034888#comment-13034888 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
Finally I found the culprit: it looks like there is a little difference between the jvm implementations (5,6).
Particularly, if you set a breakpoint at line 2725 of the [OgnlRuntime Class|http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java?revision=1103138&view=markup], running the test, you will realize that the 1.5 version behave a just a bit different from the 1.6 implementation (see the order of the array methods).
OGNL works fine with 1.6 by sheer coincidence, after all if you are looking for a property/getter for the name "next" which is the best candidate between the method hasNext and the one called next (I would say next, but I'm afraid it's a matter of taste)
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-9) Upgrade JUnit to version4
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi updated OGNL-9:
------------------------------
Attachment: ognl-9.patch
While migrating to Junit4 I didn't understand what the hell I did but there is a LARGE number of tests that fail :(
(dark side of the story is I wasted a lot of time on refactoring code)
Does someone with fresh mind have some spare time to review the attached patch and see where the problem is?
Please refer to {{FIXME}} notations on Javadoc and {{@Ignore}} annotations to mute failures.
Thanks in advance!
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034658#comment-13034658 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
Thank you Simone,
but it too soon to declare victory. According Hudson there is still a test which fails.
It's very weird, if I run CollectionDirectPropertyTest it works fine.
Have you tried to run mvn test?
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034163#comment-13034163 ]
Simone Tripodi commented on OGNL-9:
-----------------------------------
WOW amazing, thanks!!! Please don't forget to explain me which kind of mistake I did :D
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-9) Upgrade JUnit to version4
Posted by "Maurizio Cucchiara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034678#comment-13034678 ]
Maurizio Cucchiara commented on OGNL-9:
---------------------------------------
IIRC there was a couple of commented test parameter, let me investigate.
> Upgrade JUnit to version4
> -------------------------
>
> Key: OGNL-9
> URL: https://issues.apache.org/jira/browse/OGNL-9
> Project: OGNL (Incubating)
> Issue Type: Task
> Reporter: Simone Tripodi
> Assignee: Simone Tripodi
> Attachments: ognl-9.patch
>
>
> Actually OGNL is tested using JUnit3; in Commons we've been migrating tests to JUnit4, as a first step just upgrading the dependency and refactoring the Test classes just by dropping the TestCase inheritance and using the annotation would be enough (methods refactoring dropping the 'test' prefix can be postponed).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira