You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/04/07 21:12:05 UTC

Review Request 20098: jmx NODEMANAGER metrics dont display when we customize NODEMANAGER port

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20098/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk and Dmitro Lisnichenko.


Bugs: AMBARI-5376
    https://issues.apache.org/jira/browse/AMBARI-5376


Repository: ambari


Description
-------

NODEMANAGER and HISTORYSERVER JMS port can't be customized


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java ced22b1 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 8701ff1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 412b066 

Diff: https://reviews.apache.org/r/20098/diff/


Testing
-------

All unittests passed.


Thanks,

Dmytro Sen


Re: Review Request 20098: jmx NODEMANAGER metrics dont display when we customize NODEMANAGER port

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20098/#review39715
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On April 7, 2014, 7:12 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20098/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 7:12 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5376
>     https://issues.apache.org/jira/browse/AMBARI-5376
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NODEMANAGER and HISTORYSERVER JMS port can't be customized
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java ced22b1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 8701ff1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 412b066 
> 
> Diff: https://reviews.apache.org/r/20098/diff/
> 
> 
> Testing
> -------
> 
> All unittests passed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 20098: jmx NODEMANAGER metrics dont display when we customize NODEMANAGER port

Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20098/#review39718
-----------------------------------------------------------

Ship it!


Ship It!

- Artem Baranchuk


On April 7, 2014, 7:37 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20098/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 7:37 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5376
>     https://issues.apache.org/jira/browse/AMBARI-5376
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> NODEMANAGER and HISTORYSERVER JMS port can't be customized
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java ced22b1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 8701ff1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 412b066 
> 
> Diff: https://reviews.apache.org/r/20098/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.476s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.226s]
> [INFO] Ambari Web ........................................ SUCCESS [9.236s]
> [INFO] Ambari Views ...................................... SUCCESS [1.241s]
> [INFO] Ambari Server ..................................... SUCCESS [11:47.882s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.203s]
> [INFO] Ambari Client ..................................... SUCCESS [0.447s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 20098: jmx NODEMANAGER metrics dont display when we customize NODEMANAGER port

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20098/
-----------------------------------------------------------

(Updated April 7, 2014, 7:37 p.m.)


Review request for Ambari, Artem Baranchuk and Dmitro Lisnichenko.


Bugs: AMBARI-5376
    https://issues.apache.org/jira/browse/AMBARI-5376


Repository: ambari


Description
-------

NODEMANAGER and HISTORYSERVER JMS port can't be customized


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java ced22b1 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 8701ff1 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 412b066 

Diff: https://reviews.apache.org/r/20098/diff/


Testing (updated)
-------

[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.476s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.226s]
[INFO] Ambari Web ........................................ SUCCESS [9.236s]
[INFO] Ambari Views ...................................... SUCCESS [1.241s]
[INFO] Ambari Server ..................................... SUCCESS [11:47.882s]
[INFO] Ambari Agent ...................................... SUCCESS [14.203s]
[INFO] Ambari Client ..................................... SUCCESS [0.447s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen