You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@geaflow.apache.org by GitBox <gi...@apache.org> on 2026/08/03 14:22:03 UTC

[GH] (geaflow/fix/issue-796-partition-type-todo): Workflow run "Java CI with Maven On JDK 11" is working again!

The GitHub Actions job "Java CI with Maven On JDK 11" on geaflow.git/fix/issue-796-partition-type-todo has succeeded.
Run started by GitHub user yyyCode (triggered by Leomrlin).

Head commit for run:
c0d6bc2e7ee292406926e14937f7fa5c141d0583 / yqz <26...@qq.com>
[ISSUE-796] Clean up PartitionType TODOs in rocksdb store module

The `PartitionType` enum in the rocksdb store carried two stale `TODO`s:

- `// TODO: Support dt partition` on `DT` — DT partition is already
  implemented (`SyncGraphDtPartitionProxy`, dispatched by `ProxyBuilder`),
  so the TODO is removed.
- `// TODO: Support label dt partition` on `DT_LABEL` — this combination
  has no proxy implementation. Configuring it previously fell through to a
  generic "unexpected partition type" error. `ProxyBuilder.build` now
  rejects `DT_LABEL` explicitly with a message that names the unsupported
  type, and the TODO is replaced with a NOTE documenting the gap.

Adds `PartitionTypeTest` covering the enum lookup/flags, the explicit
`DT_LABEL` rejection, and that `DT` is still dispatched to a real proxy.
The test targets `ProxyBuilder` directly so it does not depend on opening
a native RocksDB instance.

Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>

Report URL: https://github.com/apache/geaflow/actions/runs/30743776581

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: builds-unsubscribe@geaflow.apache.org
For additional commands, e-mail: builds-help@geaflow.apache.org