[GitHub] icexelloss commented on a change in pull request #23739: [SPARK-26832][SQL][PYTHON] Avoid project creation per record at Python's grouped vectorized UDF

[GitBox <gi...@apache.org>]

icexelloss commented on a change in pull request #23739: [SPARK-26832][SQL][PYTHON] Avoid project creation per record at Python's grouped vectorized UDF
URL: https://github.com/apache/spark/pull/23739#discussion_r254522920
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/FlatMapGroupsInPandasExec.scala
 ##########
 @@ -145,7 +145,8 @@ case class FlatMapGroupsInPandasExec(
         sessionLocalTimeZone,
         pythonRunnerConf).compute(grouped, context.partitionId(), context)
 
-      columnarBatchIter.flatMap(_.rowIterator.asScala).map(UnsafeProjection.create(output, output))
 
 Review comment:
   I think the patch is cleaner but perhaps the PR title is not accurate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org