You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2023/09/27 07:03:57 UTC
[PR] Correct quotation in drill query files (druid)
kgyrtkirk opened a new pull request, #15044:
URL: https://github.com/apache/druid/pull/15044
Literals were sometimes incorrectly quoted: ` WHERE c2 >= "b" and c2 <= "d" ORDER BY tile, c1`
This patch changes those to use `'`.
This was essentially created by re-copying the original queries and running:
```
find . -name '*.q'|xargs sed -r -i 's/`(.*.parquet|allData.csv)`/"\1"/g;s/;$//g'
```
There was 1-2 queries which were further modified - I've retained the existing in-repo versions for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Correct quotation in drill query files (druid)
Posted by "soumyava (via GitHub)" <gi...@apache.org>.
soumyava merged PR #15044:
URL: https://github.com/apache/druid/pull/15044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Correct quotation in drill query files (druid)
Posted by "soumyava (via GitHub)" <gi...@apache.org>.
soumyava commented on PR #15044:
URL: https://github.com/apache/druid/pull/15044#issuecomment-1742402817
@kgyrtkirk let's merge this one in, letme know if you agree and I'll merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org