You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benno Evers <be...@yandex-team.ru> on 2017/09/07 15:22:43 UTC

Review Request 62162: Revert usage of `-isystem` flag.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62162/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

This flag break the build of mesos against system libraries
installed under /usr, because it generates a command line
of `-isystem /usr/include`, which is explicitly not supported
by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129


Diffs
-----

  configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a 
  src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 


Diff: https://reviews.apache.org/r/62162/diff/1/


Testing
-------


Thanks,

Benno Evers

Re: Review Request 62162: Revert usage of `-isystem` flag.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62162/#review184834
-----------------------------------------------------------



Bad review!

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On Sept. 7, 2017, 8:22 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62162/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 8:22 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> 
> 
> Diffs
> -----
> 
>   configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a 
>   src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 
> 
> 
> Diff: https://reviews.apache.org/r/62162/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>