You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2010/12/24 23:22:45 UTC
[jira] Created: (HIVE-1867) Fix failure in
TestNegativeCliDriver/dyn_part_empty.q introduced in HIVE-1846
Fix failure in TestNegativeCliDriver/dyn_part_empty.q introduced in HIVE-1846
-----------------------------------------------------------------------------
Key: HIVE-1867
URL: https://issues.apache.org/jira/browse/HIVE-1867
Project: Hive
Issue Type: Bug
Components: Testing Infrastructure
Reporter: Carl Steinbach
Assignee: Joydeep Sen Sarma
Priority: Blocker
The patch for HIVE-1846 is a causing a failure in TestNegativeCliDriver/dyn_part_empty.q
See https://hudson.apache.org/hudson/job/Hive-trunk-h0.20/449/
@Joy: Can you please take a look?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1867) Add mechanism for disabling tests with
intermittent failures
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1867:
---------------------------------
Fix Version/s: 0.7.0
> Add mechanism for disabling tests with intermittent failures
> ------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
> Fix For: 0.7.0
>
> Attachments: HIVE-1867.1.patch
>
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1867:
---------------------------------
Description:
{code}
[junit] Begin query: dyn_part_empty.q
[junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
[junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
[junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
{code}
dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
was:
The patch for HIVE-1846 is a causing a failure in TestNegativeCliDriver/dyn_part_empty.q
See https://hudson.apache.org/hudson/job/Hive-trunk-h0.20/449/
@Joy: Can you please take a look?
Assignee: (was: Joydeep Sen Sarma)
Summary: Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q (was: Fix failure in TestNegativeCliDriver/dyn_part_empty.q introduced in HIVE-1846)
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
> Priority: Blocker
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005978#comment-13005978 ]
Carl Steinbach commented on HIVE-1867:
--------------------------------------
Review request: https://reviews.apache.org/r/492/
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
> Attachments: HIVE-1867.1.patch
>
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "Marcel Kornacker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Kornacker updated HIVE-1867:
-----------------------------------
Attachment: HIVE-1867.1.patch
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
> Attachments: HIVE-1867.1.patch
>
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1867) Add mechanism for disabling tests with
intermittent failures
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1867:
---------------------------------
Summary: Add mechanism for disabling tests with intermittent failures (was: Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q)
> Add mechanism for disabling tests with intermittent failures
> ------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
> Attachments: HIVE-1867.1.patch
>
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "Marcel Kornacker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006743#comment-13006743 ]
Marcel Kornacker commented on HIVE-1867:
----------------------------------------
To provide some more context: Driver.execute() launches multiple tasks in parallel and ends up calling Driver.taskCleanup() if any of them fails *and* there are still running tasks. Driver.taskCleanup() calls System.exit(9).
In this particular test, one of the tasks is meant to fail, and if it happens to finish while there are other tasks still running, System.exit(9) is being called and the test fails.
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
> Attachments: HIVE-1867.1.patch
>
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1867:
---------------------------------
Priority: Major (was: Blocker)
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "Marcel Kornacker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Kornacker updated HIVE-1867:
-----------------------------------
Assignee: Marcel Kornacker
Affects Version/s: 0.7.0
Status: Patch Available (was: Open)
This doesn't fix anything, it just introduces a mechanism to mark a test as disabled (by renaming it to .q.disabled) and also marks dyn_part_empty as disabled. Taking a closer look at the test, it seems like the failure is only indicative of a test failure, not an actual bug.
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005979#comment-13005979 ]
Carl Steinbach commented on HIVE-1867:
--------------------------------------
+1. Will commit if tests pass.
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
> Attachments: HIVE-1867.1.patch
>
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HIVE-1867) Add mechanism for disabling tests with
intermittent failures
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1867:
---------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk and branch-0.7. Thanks Marcel!
> Add mechanism for disabling tests with intermittent failures
> ------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 0.7.0
> Reporter: Carl Steinbach
> Assignee: Marcel Kornacker
> Fix For: 0.7.0
>
> Attachments: HIVE-1867.1.patch
>
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1867) Fix intermittent failures in
TestNegativeCliDriver/dyn_part_empty.q
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987221#action_12987221 ]
John Sichi commented on HIVE-1867:
----------------------------------
I think the cause here may be the same as in HIVE-1872; calling System.exit causes ant to freak out.
> Fix intermittent failures in TestNegativeCliDriver/dyn_part_empty.q
> -------------------------------------------------------------------
>
> Key: HIVE-1867
> URL: https://issues.apache.org/jira/browse/HIVE-1867
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Carl Steinbach
>
> {code}
> [junit] Begin query: dyn_part_empty.q
> [junit] Running org.apache.hadoop.hive.cli.TestNegativeCliDriver
> [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> [junit] Test org.apache.hadoop.hive.cli.TestNegativeCliDriver FAILED (crashed)
> {code}
> dyn_part_empty.q has been intermittently failing on Hudson. I was able to reproduce locally,
> and with different versions of JUnit (3.8.1, 4.5, 4.8.2).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.