You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/15 22:10:24 UTC

[GitHub] [arrow] kou commented on a change in pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

kou commented on a change in pull request #7192:
URL: https://github.com/apache/arrow/pull/7192#discussion_r426068491



##########
File path: dev/release/binary-task.rb
##########
@@ -610,7 +610,7 @@ def download_url(url, output_path)
               $stderr.puts(build_download_error_message(url, response))
               return
             else
-              raise message

Review comment:
       Oh, sorry.
   We should show request/response details to know what error is occurred.
   
   I've pushed a commit that raises an exception with the request/response details.
   We'll be able to know what response should be handled here to retry download. Then we can improve our retry code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org