[jira] [Commented] (SOLR-11460) review values used in test-files

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198966#comment-16198966 ] 

Christine Poerschke commented on SOLR-11460:
--------------------------------------------

{code}
git grep -n "<luceneMatchVersion>.*</luceneMatchVersion>" | grep /test-files/ | sed 's/.*\(<luceneMatchVersion.*luceneMatchVersion>\).*/\1/g' | sort | uniq -c
140 <luceneMatchVersion>${tests.luceneMatchVersion:LATEST}</luceneMatchVersion>
  9 <luceneMatchVersion>${tests.luceneMatchVersion:LUCENE_CURRENT}</luceneMatchVersion>
  5 <luceneMatchVersion>6.0.0</luceneMatchVersion>
  1 <luceneMatchVersion>8.0.0</luceneMatchVersion>
  1 <luceneMatchVersion>LUCENE_4_1</luceneMatchVersion>
{code}


* The three {{<luceneMatchVersion>6.0.0</luceneMatchVersion>}} usages in {{solr/contrib/ltr}} are unintended - SOLR-11461 to change away from 6.0.0 to LATEST instead.

* The two {{<luceneMatchVersion>6.0.0</luceneMatchVersion>}} usages in {{solr/solrj}} surprised me - not sure if they are intended and/or required?

* The {{<luceneMatchVersion>LUCENE_4_1</luceneMatchVersion>}} in {{solrconfig-implicitproperties.xml}} - could it be changed to {{<luceneMatchVersion>$\{tests.luceneMatchVersion:LATEST\}</luceneMatchVersion>}} instead?

* Is there a difference between {{tests.luceneMatchVersion:LATEST}} and {{tests.luceneMatchVersion:LUCENE_CURRENT}} or could we standardise on the former? Based on LUCENE-5901 I think the answers are "no" and "yes".
** step 1: replace the remaining nine LUCENE_CURRENT usages
** step 2: change {{ant -validate-source-patterns}} (or similar) to disallow {{tests.luceneMatchVersion:LUCENE_CURRENT}} or even to allow only {{tests.luceneMatchVersion:LATEST}} and {{8.0.0}} (on master) or {{7.0.0}} (on branch_7x) etc.

Additional thoughts on this and/or help making changes welcome. Thanks!

> review <luceneMatchVersion> values used in test-files
> -----------------------------------------------------
>
>                 Key: SOLR-11460
>                 URL: https://issues.apache.org/jira/browse/SOLR-11460
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> Noticed that different test files use (unexpectedly) different {{<luceneMatchVersion>}} values. Details to follow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org